Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frameworks automigration didn't run for vue3/vite project #20148

Closed
tmeasday opened this issue Dec 8, 2022 · 2 comments
Closed

Frameworks automigration didn't run for vue3/vite project #20148

tmeasday opened this issue Dec 8, 2022 · 2 comments
Assignees

Comments

@tmeasday
Copy link
Member

tmeasday commented Dec 8, 2022

I ran npx storybook@next upgrade --tag next on https://github.com/inkline/inkline and it ran successfully, running a bunch of migrations.

However yarn storybook then failed with:

ERR! Error: Invalid value of @storybook/vue3 in the 'framework' field of Storybook config.

Due to main.js remaining:

  framework: '@storybook/vue3',
  core: {
    builder: '@storybook/builder-vite'
  },
@tmeasday tmeasday converted this from a draft issue Dec 8, 2022
@shilman shilman moved this to Todo in Core Team Projects Dec 8, 2022
@shilman shilman added the linear label Dec 8, 2022
@shilman shilman moved this from Must have for RC to Must have for beta in Core Team Projects Dec 12, 2022
@yannbf
Copy link
Member

yannbf commented Dec 14, 2022

Hey @tmeasday I tried this in the project and the automigration is correct. You probably missed the error that the vite version is not compatible.

in #20222 I'm adding a summary which should make this pretty clear, this is what will look like in that project:

Image

And after Vite is upgraded, when running automigrate as indicated in the message:

Image

If you don't mind, I'll close this issue, but feel free to reopen it if you disagree!

@yannbf yannbf closed this as completed Dec 14, 2022
Repository owner moved this from Required for beta announcement to Done in Core Team Projects Dec 14, 2022
@tmeasday
Copy link
Member Author

Great job @yannbf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants