Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Reference to @storybook/mdx1-csf still exists in 7.0 #19677

Closed
IanVS opened this issue Oct 28, 2022 · 3 comments
Closed

[Bug]: Reference to @storybook/mdx1-csf still exists in 7.0 #19677

IanVS opened this issue Oct 28, 2022 · 3 comments

Comments

@IanVS
Copy link
Member

IanVS commented Oct 28, 2022

Describe the bug

A user was having a problem in Discord, getting this warning:

image

The only place I can still see @storybook/mdx1-csf still being referenced is in

module.exports = require('@storybook/mdx1-csf').createCompiler;
, but that file itself doesn't seem to be used anywhere. So I'm not certain what's going on. But it seems like this reference should be removed or updated, maybe?

To Reproduce

No response

System

No response

Additional context

The thread in discord: https://discord.com/channels/486522875931656193/1035550969632661555

@emojivibe
Copy link

can i do this?

@IanVS
Copy link
Member Author

IanVS commented Oct 29, 2022

Sorry, it's already done in #19681

@shilman
Copy link
Member

shilman commented Nov 1, 2022

Egads!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.0.0-alpha.47 containing PR #19681 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb upgrade --prerelease

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants