Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar stories overflow container #177

Closed
jamieholliday opened this issue May 9, 2016 · 3 comments
Closed

Sidebar stories overflow container #177

jamieholliday opened this issue May 9, 2016 · 3 comments
Labels

Comments

@jamieholliday
Copy link
Contributor

jamieholliday commented May 9, 2016

I have a long list of stories which overflow the size of the stories sidebar as no scrollbar is rendered.
I tried following the instructions in the docs to override the component and fix this issue by setting a height to the stories container. https://github.com/kadirahq/react-storybook/blob/master/docs/configure_storybook.md#customizing-the-ui - but this isn't overriding. I tried finding the layout.js file referenced from that doc but the link is broken
https://raw.githubusercontent.com/kadirahq/react-storybook/master/src/client/ui/layout.js
I'm not sure which file to overing now in this case
screen shot 2016-05-09 at 14 49 34

I am running version 1.22.1

@arunoda arunoda added the bug label May 9, 2016
@arunoda
Copy link
Member

arunoda commented May 9, 2016

Yep. This seems like a bug.
I'll work on it.

@arunoda
Copy link
Member

arunoda commented May 10, 2016

Try version 1.24.0 or higher.
It comes with a fix for this.

Reopen, if that's not what you are looking for.

@arunoda arunoda closed this as completed May 10, 2016
@jamieholliday
Copy link
Contributor Author

This does work. As an improvement I was thinking the filter bar could be always visible at the top and just the stories scroll. I have created a PR with those changes in here:
#182

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants