-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues with starting Storybook after upgrading to CRA 5 #17454
Comments
I think I more or less confirmed that the issue was |
Not exactly unrelated, |
Also relevant, we use Yarn Plug'N'Play. |
I'm getting exactly the same issue, after moving our project over to Plug'n'Play. |
If it saves you any time, what I did to temporarily resolve the issue was resolve webpack to |
I'm getting exactly the same issue too. Then not found package error occur |
In a complex Storybook project (such as mine), setting a resolution at the top level isn't possible. I found the issue to be resolved by updating |
This worked in our particular case because we upgraded all of our microservices to use Webpack 5 exclusively at the same time. |
Thank you @WoodyWoodsta, that worked for me! Note: using the latest alpha which is // package.json
{
"resolutions": {
...,
+ "@storybook/react": "6.5.0-alpha.42"
},
...
} EDIT: quick update, it appears the original issue is no longer happening with |
Chiming in to say thanks for this. I originally thought it was this issue, so linking for visibility: #15336 |
Got this problem with react script 5.0.1 and storybook 7.0.3 Removed package-lock.json and node_modules and ran |
We’re cleaning house! Storybook has changed a lot since this issue was created and we don’t know if it’s still valid. Please open a new issue referencing this one if:
|
Describe the bug
I'm in the process of upgrading some of the front ends in our repository to CRA 5 from 4.0.3. I've ran into a hiccup while upgrading with Storybook, I ran through the steps in https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#cra5-upgrade and used the automigrate method. I also upgraded
@storybook/preset-create-react-app
to4.0.0
. I will note that we are using yarn with workspaces and that might be a part of the source of the issues. Anyway, here is the error that I'm currently dealing with:I'm not entirely sure of the source of this error, but it looks like at some point another version of webpack is being used than
5.68.0
, specifically4.46.0
.To Reproduce
I don't know if this is easily reproducible.
System
Environment Info:
System:
OS: macOS 12.2
CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
Binaries:
Node: 16.13.0 - /usr/local/bin/node
Yarn: 3.0.2 - /usr/local/bin/yarn
npm: 8.1.0 - /usr/local/bin/npm
Browsers:
Chrome: 98.0.4758.80
Edge: 98.0.1108.43
Firefox: 95.0.2
Safari: 15.3
Additional context
I thought I would include my package versions and storybook config/storybook webpack config in the failing project for good measure:
dependencies:
storybook configs:
The text was updated successfully, but these errors were encountered: