Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PropTypes show up as node incorrectly in static build. #1723

Closed
danielduan opened this issue Aug 23, 2017 · 1 comment
Closed

PropTypes show up as node incorrectly in static build. #1723

danielduan opened this issue Aug 23, 2017 · 1 comment
Labels
addon: info bug

Comments

@danielduan
Copy link
Member

When propTypes are generated using the fallback method, they don't have a type attached and we wrongly assume that it is of type node.

The fallback gets used when propTypes are defined in a separate file and imported.
@danielduan danielduan changed the title PropTypes show up as node when undefined. PropTypes show up as node incorrectly in static build. Aug 28, 2017
@billyvg billyvg mentioned this issue Aug 29, 2017
Merged
@danielduan danielduan mentioned this issue Oct 31, 2017
Closed
This was referenced Jan 12, 2018
Closed
Closed
@issue-sh issue-sh bot removed the todo label Apr 3, 2018
@danielduan
Copy link
Member Author

This is more of a react-docgen issue than anything else. I'll update the docgen plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
addon: info bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@danielduan