Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(dependencies) Update @mdx-js/mdx once a stable new version is released in csf-tools #17137

Closed
VanessaHenderson opened this issue Jan 5, 2022 · 4 comments

Comments

@VanessaHenderson
Copy link
Contributor

Describe the bug
The library currently used in @storybook/csf-tools v6.4.9 uses @mdx-js/mdx ^1.6.22. This version of mdx ultimately uses version 0.0.1 of the trim dependency which has a vulnerability (when using npm at least).
Right now the transitive path is
Screen Shot 2022-01-06 at 8 46 35 AM

Remark-parse stops using trim in version 9.0.0. mdx-js updates to 9.0.0 in this commit. However, the only versions of mdx-js that have been released since this update are release candidates and not a stable version.

When @mdx-js/mdx releases a stable new version, @storybook/csf-tools should upgrade to avoid having the transitive trim vulnerability

To Reproduce
Run npm ls trim on a project using @storybook/csf-tools

System
Please paste the results of npx sb@next info here.

Additional context
:)

@VanessaHenderson
Copy link
Contributor Author

A new version of mdx has been released, https://github.com/mdx-js/mdx/releases/tag/2.0.0 This contains the fix for the trim vulnerability

@shilman
Copy link
Member

shilman commented Feb 21, 2022

Filed mdx-js/mdx#1945

@shilman shilman mentioned this issue Feb 22, 2022
6 tasks
@shilman
Copy link
Member

shilman commented Feb 28, 2022

Yee-haw!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.5.0-alpha.43 containing PR #17515 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb upgrade --prerelease

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Feb 28, 2022
@shilman
Copy link
Member

shilman commented Feb 28, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants
@shilman @VanessaHenderson and others