Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: honor PREVIEW_URL in non-inlined stories #16775

Closed
ittaibaratz opened this issue Nov 24, 2021 · 1 comment
Closed

docs: honor PREVIEW_URL in non-inlined stories #16775

ittaibaratz opened this issue Nov 24, 2021 · 1 comment

Comments

@ittaibaratz
Copy link
Contributor

ittaibaratz commented Nov 24, 2021

Is your feature request related to a problem? Please describe

For our internal build system, we need PREVIEW_URL to be honored not just for normal stories, but also for non-inlined stories, as we use the docs add-on in some of our newer stories.

Describe the solution you'd like

non-Inline stories in docs (inlineStories = false) should respect PREVIEW_URL as they iframe the stories.

Describe alternatives you've considered

The only alternative is to inline our stories, but this is impossible because of their styles.

Are you able to assist to bring the feature to reality?
Yes! I've made this simple PR to enable this feature: #16773 , if someone can review it we can continue the conversation there. I've tested this PR locally against my project and it works well.

Additional context
Add any other context or screenshots about the feature request here.

@shilman
Copy link
Member

shilman commented Dec 9, 2021

Jiminy cricket!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.5.0-alpha.3 containing PR #16773 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb upgrade --prerelease

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants