Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addons-info missing typescript declarations #1669

Closed
tko opened this issue Aug 17, 2017 · 6 comments
Closed

addons-info missing typescript declarations #1669

tko opened this issue Aug 17, 2017 · 6 comments

Comments

@tko
Copy link
Contributor

tko commented Aug 17, 2017

While type definitions for many of the addons (knobs, links, notes, options, actions) seem to exist in DefinitelyTyped repository, there's none for addons-info.

@danielduan
Copy link
Member

You're more than welcome to submit a PR and add them

@mkornblum
Copy link

I just opened one on DefinitelyTyped here - DefinitelyTyped/DefinitelyTyped#20538

It wasn't 100% clear to me if I should have opened it on this repo or that one, but I went with the other once since that is where the other addon type definitions live.

@mkornblum
Copy link

Looks like they merged it already, hope they are helpful for you!

@andrespch
Copy link

andrespch commented Nov 9, 2017

hey @mkornblum did you manage to get the propTypes descriptions working properly with TypeScript? it won't show the types for me, and will only show the propTypes section if I add defaultProps. I define my props like this

interface ActionButtonProps extends React.Props<ActionButton> {
  text?: string;
  onTap?(): void;
  disabled?: boolean;
}

interface State {}

export default class ActionButton extends RX.Component<
  ActionButtonProps,
  State
> {}

@stale
Copy link

stale bot commented Dec 24, 2017

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 60 days. Thanks!

@stale stale bot added the inactive label Dec 24, 2017
@stale
Copy link

stale bot commented Jan 8, 2018

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants