Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controls Addon - Vue - Update property without re-rendering story #15567

Closed
rtrap-rsi opened this issue Jul 13, 2021 · 8 comments · Fixed by #20712
Closed

Controls Addon - Vue - Update property without re-rendering story #15567

rtrap-rsi opened this issue Jul 13, 2021 · 8 comments · Fixed by #20712

Comments

@rtrap-rsi
Copy link

Describe the bug
When updating vue props thorugh Controls the component remount (mounted lifecycle method relaunched)

To Reproduce
https://github.com/rtrap-rsi/vue-storybook-remount-issue

@tmeasday
Copy link
Member

That repository doesn't appear to include Storybook, did you forget to check something in?

@rtrap-rsi
Copy link
Author

rtrap-rsi commented Jul 14, 2021 via email

@tmeasday
Copy link
Member

tmeasday commented Jul 22, 2021

It does seem like vue3 isn't behaving as it "should" here @shilman.

@mirabledictu
Copy link

Can confirm this

@wobsoriano
Copy link

Can I add that the source code block in the docs tab doesn't appear automatically?

@shilman shilman added P1 and removed needs triage labels Aug 7, 2021
@bisubus
Copy link
Contributor

bisubus commented Apr 27, 2022

Are there any workarounds currently for this? Sadly, this makes controls much less unusable. 6.4.0-alpha.34 here.

@daniellacosse
Copy link

daniellacosse commented May 15, 2022

Encountering this as well. It breaks any reactivity related to props changes. At first I thought I wasn't migrating from Vue2 to Vue3 correctly 😅

@shilman
Copy link
Member

shilman commented Jan 24, 2023

Ooh-la-la!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.0.0-beta.32 containing PR #20712 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb@next upgrade --prerelease

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants