-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide menu toggle and toggle panel when toggling fullscreen in singleStory mode #15553
Comments
Related UX changes for the toolbar + sidebar + addon panel toggles here |
hey, I can take this one |
@alk-mandrianarijaona Thank you for helping make Storybook better! 🙏 Please check out how to contribute in our docs and feel free to ask questions in |
@shilman @domyen @ghengeveld can you guys tell me what's the way to check if there is an addon panel to display? |
edit: hmm I think I am wrong here |
See storybook/lib/ui/src/index.tsx Line 49 in 8c32662
|
Ta-da!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.4.0-beta.24 containing PR #15755 that references this issue. Upgrade today to the
Closing this issue. Please re-open if you think there's still more to do. |
Jeepers creepers!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.4.0-beta.25 containing PR #15755 that references this issue. Upgrade today to the
|
When using
singleStory=true
(query param), there should be no way to bring up the sidebar. Currently there's two icons to toggle it:The menu toggle should be hidden in singleStory mode. The fullscreen toggle should toggle the addon panel if there are any, or not be displayed either.
The text was updated successfully, but these errors were encountered: