Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding/removing stories do not automatically update in React Native (3.2) #1547

Closed
atticoos opened this issue Jul 30, 2017 · 4 comments
Closed

Comments

@atticoos
Copy link
Member

Story lists (on device, and on web) no longer automatically add or remove stories as they are added or removed in the codebase. It currently requires a full refresh of the web and device to observe these changes.

@shilman
Copy link
Member

shilman commented Jul 30, 2017

@ajwhite I am confused about this bug: 😕

  • can reproduce in examples/react-native-vanilla on master
  • can reproduce in examples/react-native-vanilla on @rmevans9 's PR branch
  • CANNOT reproduce on a CRNA side project with the latest alpha (which should be equivalent to master)

@rmevans9
Copy link
Contributor

After speaking with @shilman about this and taking a quick look at it here are my findings on this issue which could make it a non-issue:

React Native has Hot Module Reloading built into it. If you have it on the components of the app reload when a story is added and the menus (both on web and OnDeviceUI) update accordingly. If you have it off the app doesn't reload the stories and thus the story doesn't propagate to the menus.

CRNA uses Expo under the covers which I am fairly certain has a HMR type setup that is baked in during development which means when you update a story the RN app reloads the needed components and the stories appear in the menus.

I believe this is a non-issue as any sane RN dev that is working on adding stories should have HMR on.

@shilman
Copy link
Member

shilman commented Jul 30, 2017

Agree with @rmevans9 and closing. And here's a screenshot for anybody who runs across this issue:

glass

@shilman shilman closed this as completed Jul 30, 2017
@rmevans9
Copy link
Contributor

@shilman Either that or the "Enable Hot Reloading" below will do. Personally I use "Enable Hot Reloading" because it updates the component in place without reloading the entire bundle. "Enable Live Reload" will reload the entire app bundle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants