Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Accept singleStory param in manager #15125

Closed
ghengeveld opened this issue Jun 2, 2021 · 1 comment
Closed

Core: Accept singleStory param in manager #15125

ghengeveld opened this issue Jun 2, 2021 · 1 comment
Assignees
@ghengeveld
Labels
core feature request
Milestone
6.3 improvements

Comments

@ghengeveld
Copy link
Member

ghengeveld commented Jun 2, 2021 •
edited by sync-by-unito bot
Loading

#14875 introduced the singleStory=true param on iframe.html. In order to take advantage of this for embedding index.html, we should accept this flag there too, and propagate it to iframe.html.
@ghengeveld ghengeveld added this to the 6.3 improvements milestone Jun 2, 2021
@ghengeveld ghengeveld self-assigned this Jun 2, 2021
@ghengeveld ghengeveld changed the title Accept singleStory param on index.html Accept singleStory param in manager Jun 2, 2021
@ghengeveld ghengeveld changed the title Accept singleStory param in manager Core: Accept singleStory param in manager Jun 2, 2021
@ghengeveld
Copy link
Member Author

Turns out the manager already propagates any unknown/unhandled query params to the iframe.

@shilman shilman added the tiny label Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ghengeveld ghengeveld

Labels
core feature request
Projects
None yet
Milestone
6.3 improvements
Development

No branches or pull requests
2 participants
@ghengeveld @shilman