Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addon-toolbars: add support for keyboard shortcuts/navigation #14239

Closed
kaelig opened this issue Mar 15, 2021 · 5 comments
Closed

addon-toolbars: add support for keyboard shortcuts/navigation #14239

kaelig opened this issue Mar 15, 2021 · 5 comments

Comments

@kaelig
Copy link
Contributor

kaelig commented Mar 15, 2021

Is your feature request related to a problem? Please describe
I'd like to be able to switch easily between, say, dark and light mode in a Story (or cycle through multiple themes).

Describe the solution you'd like
Not sure how this could work in practice, curious if anyone has ideas on how to make that work.

Are you able to assist to bring the feature to reality?
Probably not, sorry!

@frassinier
Copy link
Contributor

What do you mean @kaelig? Be able to assign key shortcuts when you register an addon?

@kaelig
Copy link
Contributor Author

kaelig commented Apr 29, 2021

I suppose that was just made possible via #14658?

(related: #14401)

@frassinier
Copy link
Contributor

@Dschungelabenteuer can you relate? 😊

@Dschungelabenteuer
Copy link
Member

Dschungelabenteuer commented Apr 29, 2021

Yes, as of #14658 this should not be a problem using the extended shortcut API :) I can create a pull request if you guys want, but we should first agree on the different shortcuts (especially regarding cross-OS compatibility) since @kaelig pointed out an unforseen issue in the original PR 😅 I should actually get myself a macOS-powered environment!

@shilman
Copy link
Member

shilman commented Jun 8, 2021

Jeepers creepers!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.3.0-beta.18 containing PR #15169 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb upgrade --prerelease

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants