Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Array knob of empty string converts to an array of [""] #1404

Closed
pmwisdom opened this issue Jul 3, 2017 · 5 comments
Closed

Array knob of empty string converts to an array of [""] #1404

pmwisdom opened this issue Jul 3, 2017 · 5 comments

Comments

@pmwisdom
Copy link

pmwisdom commented Jul 3, 2017

When I add an empty array knob to a component, aka:

array('Label', []) it shows correctly in the knob panel that its empty, and the component receives the prop [], but when I add a comma delimited string to the knob input (say, hello, world, which converts to ['hello', 'world'] correctly) and then delete the string from the knob panel (back to "") my component receives [""], when it should receive [].

My solution for this is to create a patched component, but I believe this to be a bug.

Example workaround:

//patched-array.js
import {array} from '@storybook/addon-knobs';

const removeEmptyEntries = arr => {
	return arr.filter(e => Boolean(e));
};

const patchedArray = (name, value) => {
	return removeEmptyEntries(array(name, value));
};

export default patchedArray;
@dangreenisrael
Copy link
Member

Should this not be closed?

@Hypnosphi
Copy link
Member

Hypnosphi commented Sep 19, 2017

@dangreenisrael
Copy link
Member

Makes sense, thanks @Hypnosphi. Thanks for the clarification

@stale
Copy link

stale bot commented Nov 14, 2017

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 60 days. Thanks!

@stale stale bot added the inactive label Nov 14, 2017
@Hypnosphi
Copy link
Member

Fixed in 3.3.0-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants