Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Fix toggle button for custom theming #13924

Closed
shilman opened this issue Feb 16, 2021 · 8 comments
Closed

UI: Fix toggle button for custom theming #13924

shilman opened this issue Feb 16, 2021 · 8 comments

Comments

@shilman
Copy link
Member

shilman commented Feb 16, 2021

The search input on the left nav is working correctly but I think still some bugs in the custom theme configuration.

The switch buttons under control it's taking the toolbar background.

UI-Elements-Form-Controls-Buttons-Primary-⋅-Storybook

The arrows in the left nav on hover, focus, and the active effect are taking the parameters from barSelectedColor

left-nav-Storybook

Originally posted by @nerisina in #13388 (comment)

@cjmcintyre
Copy link
Contributor

90% sure I've found the cause of this - will get a PR in soon.

@singharyan1007
Copy link

hey i am new ..can you assign me this issue and help me out with it

@shilman shilman added the tiny label May 6, 2021
@shilman
Copy link
Member Author

shilman commented May 10, 2021

Jeepers creepers!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.3.0-alpha.22 containing PR #14408 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb upgrade --prerelease

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed May 10, 2021
@shilman shilman reopened this May 10, 2021
@Nazeeh21
Copy link
Contributor

I want to give it a try to resolve this issue.

@shilman
Copy link
Member Author

shilman commented Jun 29, 2021

Thanks @Nazeeh21!

@Nazeeh21
Copy link
Contributor

Nazeeh21 commented Jun 30, 2021

I am getting this error while running the command yarn build as specified here

image

Error message displays MODULE NOT FOUNDin spite of running yarn in the root directory.
Do I need to install another package globally or folder specific for this?

I am able to run storybook locally though.
image

@shilman
Copy link
Member Author

shilman commented Jul 1, 2021

@Nazeeh21 maybe it's having problems with the space in your directory name. can you try it in path that doesn't have a space in the name?

@shilman
Copy link
Member Author

shilman commented Jul 13, 2021

Olé!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.4.0-alpha.15 containing PR #15449 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb upgrade --prerelease

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants