-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow disabling the progressbar plugin with a commandline flag #1260
Comments
Was just about to ask about this myself. It clashes with my default dev task CLI output. :) |
I'm for silencing the webpack progress by default. The output makes configuring compilation on IDEs like WebStorm a nightmare as well. Has anyone tried |
This was introduced in version |
It was introduced in this commit, that add adds the ProgressPlugin: 7c707f6 |
Temporary fix is to remove the plugin from webpack config you create: const webpack = require('webpack');
module.exports = (config, env) => {
config.plugins = config.plugins.filter(plugin => !(plugin instanceof webpack.ProgressPlugin))
return config;
}; |
@thebuilder the release notes are a concatenation of every closed PR that is not labeled with the @ndelangen we should be more disciplined about not lumping too many separate issues into PR's |
@thebuilder yeah but unfortunately it's not that easy to alter the storybook's webpack config in a project created by CRA or CRNA. @shilman well, a small & focus PR is always better, right? |
@luftywiranda13 @ndelangen did some seriously heavy lifting on the project, e.g. enabling strict linting (for which we should all be grateful!) and it would have been impractical to split it up into many PR's. the downside is that when we get sloppy, stuff like this doesn't make it into the changelog. |
I'm sorry if this inconvenienced you! I can try write a ProgressPlugin myself that doesn't have this issue. but of course the best option would be for me or someone else to actually fix this in webpack. We should actually file a bug for this on webpack ProgressPlugin. I have been looking for a good entry point to start contributing to webpack, but I fear that it would mean I'd get too much on my plate. There's only so much I can do. I'm trying to be disciplined and only do 1 thing in 1 PR, but of course the fact is also there's a lot going on. @danielduan I have tried the @luftywiranda13 It's not actually stuck, it does reach 100%, but the terminal doesn't print the output right. It's probably that the ProgressPlugin doesn't account for the max-length (screen-width) of the terminal correctly, causing line that are supposed to be on 1 line wrap to 2 lines. @thebuilder Thanks for sharing your solution! |
@ndelangen I think it's fine with a ProgressPlugin - Just think it should be possible to disable and/or configure it. A |
@ndelangen to have it be configurable from storybook sounds good to me, I agree with @thebuilder |
Toggleable sounds OK to me. |
start-storybook
CLI output
So who's interested in turning this issue into a PR? |
Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 60 days. Thanks! |
Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook! |
You can disable this with: storybook/lib/core/src/server/cli/dev.js Line 29 in c604b26
from the docs:
|
The I found this approach works best for me with Nx. Here is how I run 3 storybooks from projects named
|
I'm using custom config as suggested in https://storybook.js.org/basics/writing-stories/#loading-stories-dynamically to dynamically load stories.
is there a way to tame the CLI outputs of
start-storybook
a little bit? cause currently it's too noisy to meThe text was updated successfully, but these errors were encountered: