-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI: update missing template examples to follow the new standard #12173
Comments
I think we need to update Ember (@gossi?) and HTML. Ideally each of these frameworks have a set of maintainers who will make these kinds of updates and also help document and help users of those frameworks. |
Just checked for ember, they all in CSF - no more |
@gossi the new template for React/Vue/Angular go a step further than just CSF. They have addon-essentials built in, as well as a compnent-driven example with intro/button/heading/page, which we'd like to standardize across all our frameworks. |
I see, yeah I guess this is not there yet. However there is a PR to learnstorybook repo which has some samples, that can probably help starting here (but they use redux, which is too much I guess) - but would then be better to have the same set of components as they are present for other frameworks, I guess? You can throw PRs at me but I will not have time to develop them. |
Yowza!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.1.0-alpha.0 containing PR #12286 that references this issue. Upgrade today to try it out! You can find this prerelease on the Closing this issue. Please re-open if you think there's still more to do. |
Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks! |
closing this and will track the work as the open PR for ember |
Work summary
This is a followup of #10723.
In #11505 the CLI templates for most frameworks have been updated to follow the new Component Driven (Button, Header, Pages) examples.
The examples here for Angular, React, Preact, Rax, Vue, Mithril, Web components and Svelte have been updated, so we need to check about the missing ones:
@shilman what do you think about this? Should we spend time updating/fixing all or just some of these frameworks?
I know some have quite an old syntax (marionette uses storiesOf) and I remember we had a few issues setting up the E2E for a few of these frameworks. There's a bit of work that varies depending on the frameworks.
Acceptance criteria
Who to contact
@yannbf @tooppaaa @ndelangen @gaetanmaisse
The text was updated successfully, but these errors were encountered: