Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: update missing template examples to follow the new standard #12173

Closed
1 of 8 tasks
yannbf opened this issue Aug 20, 2020 · 7 comments
Closed
1 of 8 tasks

CLI: update missing template examples to follow the new standard #12173

yannbf opened this issue Aug 20, 2020 · 7 comments
Labels
cli maintenance User-facing maintenance tasks

Comments

@yannbf
Copy link
Member

yannbf commented Aug 20, 2020

Work summary

This is a followup of #10723.
In #11505 the CLI templates for most frameworks have been updated to follow the new Component Driven (Button, Header, Pages) examples.

The examples here for Angular, React, Preact, Rax, Vue, Mithril, Web components and Svelte have been updated, so we need to check about the missing ones:

@shilman what do you think about this? Should we spend time updating/fixing all or just some of these frameworks?
I know some have quite an old syntax (marionette uses storiesOf) and I remember we had a few issues setting up the E2E for a few of these frameworks. There's a bit of work that varies depending on the frameworks.

Acceptance criteria

  • E2E tests are passing
  • Changes are properly reviewed by some of the members mentioned below

Who to contact

@yannbf @tooppaaa @ndelangen @gaetanmaisse

@shilman shilman added cli maintenance User-facing maintenance tasks labels Aug 21, 2020
@shilman
Copy link
Member

shilman commented Aug 21, 2020

I think we need to update Ember (@gossi?) and HTML. Ideally each of these frameworks have a set of maintainers who will make these kinds of updates and also help document and help users of those frameworks.

@gossi
Copy link
Contributor

gossi commented Aug 24, 2020

Just checked for ember, they all in CSF - no more storiesOf.

@shilman
Copy link
Member

shilman commented Aug 24, 2020

@gossi the new template for React/Vue/Angular go a step further than just CSF. They have addon-essentials built in, as well as a compnent-driven example with intro/button/heading/page, which we'd like to standardize across all our frameworks.

@gossi
Copy link
Contributor

gossi commented Aug 26, 2020

I see, yeah I guess this is not there yet. However there is a PR to learnstorybook repo which has some samples, that can probably help starting here (but they use redux, which is too much I guess) - but would then be better to have the same set of components as they are present for other frameworks, I guess? You can throw PRs at me but I will not have time to develop them.

@shilman
Copy link
Member

shilman commented Aug 31, 2020

Yowza!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.1.0-alpha.0 containing PR #12286 that references this issue. Upgrade today to try it out!

You can find this prerelease on the @next NPM tag.

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Aug 31, 2020
@shilman shilman reopened this Aug 31, 2020
@stale
Copy link

stale bot commented Oct 4, 2020

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Oct 4, 2020
@shilman shilman added the todo label Oct 4, 2020
@stale stale bot removed the inactive label Oct 4, 2020
@shilman
Copy link
Member

shilman commented Oct 22, 2021

closing this and will track the work as the open PR for ember

@shilman shilman closed this as completed Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli maintenance User-facing maintenance tasks
Projects
None yet
Development

No branches or pull requests

3 participants