Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a11y update in 6.0.x doesn't render accessibility results #12095

Closed
sleblang opened this issue Aug 17, 2020 · 2 comments
Closed

a11y update in 6.0.x doesn't render accessibility results #12095

sleblang opened this issue Aug 17, 2020 · 2 comments

Comments

@sleblang
Copy link

Describe the bug
Received the following console error after updating to version 6.0.12:
withA11y(options) is deprecated, please configure addon-a11y using the addParameter api:

Clicking on the Accessibility Panel in a story at the bottom/side results in the panel stating 'Initializing'

Expected behavior
Accessibility results should be shown

Screenshots
Screen Shot 2020-08-17 at 2 38 29 PM

Code snippets
Updated my code in preview.js to accommodate for the new syntax:
addParameters({ a11y: { element: '#root', manual: false }

System:

System:
OS: macOS Mojave 10.14.6
CPU: (12) x64 Intel(R) Core(TM) i9-8950HK CPU @ 2.90GHz
Binaries:
Node: 12.16.1 - ~/.nvm/versions/node/v12.16.1/bin/node
Yarn: 1.22.4 - ~/.yarn/bin/yarn
npm: 6.14.7 - ~/.nvm/versions/node/v12.16.1/bin/npm
Browsers:
Chrome: 84.0.4147.125
Firefox: 76.0.1
Safari: 13.1
npmPackages:
@storybook/addon-a11y: ^6.0.12 => 6.0.12
@storybook/addon-actions: ^6.0.12 => 6.0.12
@storybook/addon-docs: ^6.0.12 => 6.0.12
@storybook/addon-info: ^5.3.19 => 5.3.19
@storybook/addon-knobs: ^6.0.12 => 6.0.12
@storybook/addon-links: ^6.0.12 => 6.0.12
@storybook/addon-storysource: ^6.0.12 => 6.0.12
@storybook/addon-viewport: ^6.0.12 => 6.0.12
@storybook/addons: ^6.0.12 => 6.0.12
@storybook/react: ^6.0.12 => 6.0.12

@basher
Copy link

basher commented Aug 18, 2020

Thought it might be worth adding a link to the deprecated withA11y decorator bug that I've already raised.

@sleblang
Copy link
Author

sleblang commented Aug 18, 2020

Thought it might be worth adding a link to the deprecated withA11y decorator bug that I've already raised.

Thanks. I followed this suggestion - #11929 (comment) and it resolved the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants