Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI support for next.js #1193

Closed
rpersaud opened this issue Jun 5, 2017 · 3 comments
Closed

CLI support for next.js #1193

rpersaud opened this issue Jun 5, 2017 · 3 comments

Comments

@rpersaud
Copy link

rpersaud commented Jun 5, 2017

getstorybook on an empty (pages/index.js) nextjs project yields :

• Detecting project type. ✖
Cannot read property 'react-native-scripts' of undefined

@shilman
Copy link
Member

shilman commented Jun 5, 2017

I think this is just a bug. Have issued a PR (#1195) to address the problem. I believe getstorybook will do the right thing in the fallback state and no special support is needed for next.js.

@shilman shilman closed this as completed Jun 5, 2017
@shilman shilman reopened this Jun 6, 2017
@shilman
Copy link
Member

shilman commented Jun 6, 2017

@rpersaud oops, closed this prematurely. i released the fix for this yesterday. would you mind upgrading @storybook/cli and trying again to verify the fix? it would help me a lot! 🙇

@shilman shilman closed this as completed Jun 6, 2017
@rpersaud
Copy link
Author

rpersaud commented Jun 6, 2017

@shilman Yup, just upgraded and tried it - getstorybook now works! Good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants