Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Improve support of Yarn 2 in E2E tests #10797

Closed
3 tasks
gaetanmaisse opened this issue May 15, 2020 · 2 comments
Closed
3 tasks

CLI: Improve support of Yarn 2 in E2E tests #10797

gaetanmaisse opened this issue May 15, 2020 · 2 comments
Assignees
Labels
cli maintenance User-facing maintenance tasks

Comments

@gaetanmaisse
Copy link
Member

Work summary

Currently, there is only one E2E test that uses Yarn 2, it's a simple CRA setup: https://github.com/storybookjs/storybook/pull/10702/files#diff-054afb61fcbf5f01b1e17e1341d869e4R147-R154

It would be great if the package manager used when running E2E tests was a CLI param and everything needed to bootstrap and run tests were using NPM or Yarn accordingly to that param.

By doing so:

  • We will be able to have all E2E on Npm or Yarn 2 without duplicating the configs
  • Increasing the test coverage, we will become way more confidant about Yarn 2 support and non-regression

This work is part of #10723

Where to start

📚 Surely, read some doc about Yarn 2.

🏗️ Then try to extract all references to npx or npm install to functions or class that will hide the specific syntax of each package manager (i.e. use yarn dlx for Yarn instead of npx etc).

⚔️ Fight with something because it will not be so simple.

🎛️ Update the Yarn 2 E2E tests job in Circle CI config file to run E2E tests with Yarn 2 for as much framework as possible (some are incompatible with Yarn 2 for now).

Acceptance criteria

  • Current E2E tests are passing
  • New Yarn 2 E2E tests are passing
  • Changes are properly reviewed by some of the members mentioned below

Who to contact

@gaetanmaisse @ndelangen @tooppaaa @yannbf

@gaetanmaisse gaetanmaisse added cli maintenance User-facing maintenance tasks labels May 15, 2020
@yannbf yannbf mentioned this issue May 19, 2020
2 tasks
@stale stale bot added the inactive label Jun 5, 2020
@gaetanmaisse
Copy link
Member Author

Don't worry @Stale we will do it ;)

@shilman
Copy link
Member

shilman commented Jul 28, 2020

Zoinks!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.0.0-rc.16 containing PR #11354 that references this issue. Upgrade today to try it out!

You can find this prerelease on the @next NPM tag.

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli maintenance User-facing maintenance tasks
Projects
None yet
Development

No branches or pull requests

2 participants