Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addon-docs: Add layout parameter support to Preview #10789

Closed
2 tasks
shilman opened this issue May 15, 2020 · 3 comments
Closed
2 tasks

Addon-docs: Add layout parameter support to Preview #10789

shilman opened this issue May 15, 2020 · 3 comments
Labels
addon: docs block: other feature request good first issue
Milestone
6.0 docs

Comments

@shilman
Copy link
Member

shilman commented May 15, 2020 •
edited
Loading

Storybook has a new layout parameter feature built-in in 6.0 that replaces addon-centered.

The Preview component should respect the valid values: 'centered', 'padded', 'fullscreen'

Here are the layouts the Canvas uses for each value:

https://github.com/storybookjs/storybook/blob/next/lib/core/src/client/preview/StoryRenderer.tsx#L24-L52

  • Add support
  • Make sure there are test cases in official-storybook

Follow up to #8128
@shilman shilman added this to the 6.0 docs milestone May 15, 2020
@shilman
Copy link
Member Author

shilman commented May 15, 2020

cc @yannbf

@PascalPixel
Copy link
Contributor

Seems to be done in #10801

@shilman
Copy link
Member Author

shilman commented Jun 5, 2020

Thanks @PascalPixel -- indeed!

@shilman shilman closed this as completed Jun 5, 2020
@jbanulso jbanulso mentioned this issue Oct 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
addon: docs block: other feature request good first issue
Projects
None yet
Milestone
6.0 docs
Development

No branches or pull requests
2 participants
@shilman @PascalPixel