-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
addon-docs Prop Table versioned React components 'No props found for this component' #10771
Comments
Can you create a standalone repro, perhaps using @yannbf 's template? https://gist.github.com/yannbf/d7a32cfe697e71489db00bfd50e7ab5c |
Thanks for the fast reply!
I can't really recreate with the template you provided because of the privacy issue, however, I can share the output I'm trying to trace the error - it looks like its coming from a |
Update: I was reading through this thread and thought perhaps my issue might be related - I downgraded my project's version of Out of curiosity, why wasn't the removal of the fallback code path justification for a breaking change in the storybook/addon-docs package? |
@christinec01 currently props tables only work for components defined in your app/library. by the time the components are published to NPM, most the useful information has been stripped out. it's an important use case, so we'll need to figure it out, but for now we're just getting all the basics working smoothly. Re: the breaking change, we release version all core packages in sync, and we typically make one major release per year in an attempt to minimize disruption to our users. Storybook is a complex system with hundreds of contributors, so sometimes small breaking changes slip through the cracks. In this particular case, we felt that the fallback code was typically masking user babel/webpack configuration problems and adding more confusion / support burden. It partially enables your use case of props tables for "external libraries", which I don't think we considered in the decision because we don't officially support that. |
Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks! |
Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook! |
If you are reporting a bug or requesting support, start here:
Bug or support request summary
Following the Storybook setup instructions for adding Docs to my Storybook project which uses React components. After adding
'@storybook/addon-docs'
to my main.js file, and ensuring that my component field is correctThe Docs tab loads and the component renders, however the props table and code snippet are unavailable.
Steps to reproduce
This is a private repo so STR is difficult, but I'm not using anything 'custom' outside of the standard set up outlined in the addon-docs instructions.
Please specify which version of Storybook and optionally any affected addons that you're running
Thanks and please let me know if I need to provide any further detail!
The text was updated successfully, but these errors were encountered: