Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addon-docs: Use inline rendering by default in Vue #10462

Closed
shilman opened this issue Apr 17, 2020 · 1 comment
Closed

Addon-docs: Use inline rendering by default in Vue #10462

shilman opened this issue Apr 17, 2020 · 1 comment
Labels
addon: docs BREAKING CHANGE
Milestone
6.0 breaking

Comments

@shilman
Copy link
Member

shilman commented Apr 17, 2020

Addon-docs supports rendering stories in iframes or inline. The former is easier for framework authors (it's "free") and better for story isolation (e.g. no CSS bleed), but the latter is faster and more convenient in every other way. So we should set that as the default in 6.0.
@shilman shilman added this to the 6.0 breaking milestone Apr 17, 2020
@shilman shilman mentioned this issue Apr 17, 2020
Merged
@shilman
Copy link
Member Author

shilman commented Apr 18, 2020

Ta-da!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.0.0-alpha.39 containing PR #10463 that references this issue. Upgrade today to try it out!

You can find this prerelease on the @next NPM tag.

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
addon: docs BREAKING CHANGE
Projects
None yet
Milestone
6.0 breaking
Development

No branches or pull requests
1 participant
@shilman