Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflect render errors on left panel #1032

Closed
RohovDmytro opened this issue May 14, 2017 · 4 comments
Closed

Reflect render errors on left panel #1032

RohovDmytro opened this issue May 14, 2017 · 4 comments

Comments

@RohovDmytro
Copy link

RohovDmytro commented May 14, 2017

I have a proposal, but I want to hear others opinions before working on a PR.

Note: in my app I don't have tests, I don't have prop-types defined and don't use flow / typescript.

Proposal

Display a visual clue near stories that failed to render.

So left panel would be something like a test-runner for different states of a container with a fast visual feedback.

We can apply some optimisations to ensure that we don't render every component with every state on every change. For example, check only states of a selected StoryName.

Kind of example 😺

  • StoryName
    • state 1
    • state_2
    • state_3 [badge_!_]
    • state_4

Workflow

While working with a component and writing it's state_n variant, we can quickly see that we broke some of its other states.

For me it feels like writing storybook-tests, somewhat in a jest-way. If that make sense 😺

But I'm so new to storybook so I am full of doubts. 😺 Your thoughts?

@tmeasday
Copy link
Member

Have you considered using storyshots to achieve this? If you aren't interested in the full snapshot tests I'm working on a feature to just check for exceptions, as you've mentioned: #917

@tmeasday
Copy link
Member

See #1034

@stale
Copy link

stale bot commented Oct 31, 2017

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. We do try to do some housekeeping every once in a while so inactive issues will get closed after 90 days. Thanks!

@stale stale bot added the inactive label Oct 31, 2017
@stale
Copy link

stale bot commented Nov 2, 2017

Hey there, it's me again! I am going to help our maintainers close this issue so they can focus on development efforts instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!

@stale stale bot closed this as completed Nov 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants