From e65573e38424d82b670f7fc0b2d229b6cc293621 Mon Sep 17 00:00:00 2001 From: Gavin King Date: Sun, 17 Jun 2018 20:28:31 +0200 Subject: [PATCH] Creating svelte test and integration locations to match vue --- .circleci/config.yml | 11 ++++++++ .github/CODEOWNERS | 6 +++-- .../buildTypes/StotybookApp.kt | 1 + .../app-acceptance.stories.storyshot | 8 ++++++ .../stories/app-acceptance.stories.js | 1 + examples/svelte-kitchen-sink/package.json | 12 --------- .../addon-actions.stories.storyshot | 19 +++++++++++++ .../addon-backgrounds.stories.storyshot | 7 +++++ .../addon-centered.stories.storyshot | 11 ++++++++ .../addon-knobs.stories.storyshot | 11 ++++++++ .../src/stories/__snapshots__/index.storyshot | 27 +++++++++++++++++++ jest.config.js | 4 ++- package.json | 1 + scripts/build-storybooks.sh | 2 +- scripts/netlify-build.sh | 7 +++++ scripts/test.js | 16 ++++++++++- yarn.lock | 4 +++ 17 files changed, 131 insertions(+), 17 deletions(-) create mode 100644 examples/svelte-kitchen-sink/src/stories/__snapshots__/addon-actions.stories.storyshot create mode 100644 examples/svelte-kitchen-sink/src/stories/__snapshots__/addon-backgrounds.stories.storyshot create mode 100644 examples/svelte-kitchen-sink/src/stories/__snapshots__/addon-centered.stories.storyshot create mode 100644 examples/svelte-kitchen-sink/src/stories/__snapshots__/addon-knobs.stories.storyshot create mode 100644 examples/svelte-kitchen-sink/src/stories/__snapshots__/index.storyshot diff --git a/.circleci/config.yml b/.circleci/config.yml index dd5a757f5786..5b890871da1b 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -39,6 +39,7 @@ jobs: - examples/official-storybook/node_modules - examples/polymer-cli/node_modules - examples/vue-kitchen-sink/node_modules + - examples/svelte-kitchen-sink/node_modules - examples/marko-cli/node_modules - save_cache: name: "Cache core dist" @@ -72,6 +73,11 @@ jobs: command: | cd examples/vue-kitchen-sink yarn build-storybook + - run: + name: "Build svelte kitchen-sink" + command: | + cd examples/svelte-kitchen-sink + yarn build-storybook - run: name: "Build angular-cli" command: | @@ -126,6 +132,11 @@ jobs: command: | cd examples/vue-kitchen-sink yarn storybook --smoke-test + - run: + name: "Run svelte kitchen-sink (smoke test)" + command: | + cd examples/svelte-kitchen-sink + yarn storybook --smoke-test - run: name: "Run angular-cli (smoke test)" command: | diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 8b17af4b00e2..c5046de9426d 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -13,7 +13,7 @@ /addons/links/ @hypnosphi @ndelangen /addons/notes/ @alexandrebodin /addons/options/ @danielduan @UsulPro -/addons/storyshots/ @igor-dv @thomasbertet @hypnosphi +/addons/storyshots/ @igor-dv @thomasbertet @hypnosphi /addons/storysource/ @igor-dv /addons/viewport/ @saponifi3d @@ -22,16 +22,18 @@ /app/react/ @xavcz @shilman @thomasbertet /app/react-native/ @rmevans9 @danielduan @Gongreg @tmeasday /app/vue/ @thomasbertet @kazupon +/app/svelte/ /docs/ @ndelangen @shilman @hypnosphi /examples/angular-cli/ @igor-dv @alterx -/examples/cra-kitchen-sink/ @ndelangen @UsulPro @hypnosphi +/examples/cra-kitchen-sink/ @ndelangen @UsulPro @hypnosphi /examples/crna-kitchen-sink/ @Gongreg @danielduan /examples/official-storybook/ @hypnosphi @danielduan @UsulPro /examples/polymer-cli/ @naipath @igor-dv /examples/react-native-vanilla/ @tmeasday @danielduan /examples/vue-kitchen-sink/ @igor-dv @alexandrebodin +/examples/svelte-kitchen-sink/ /lib/addons/ @ndelangen @theinterned /lib/channel-postmessage/ @mnmtanish @ndelangen diff --git a/.teamcity/OpenSourceProjects_Storybook/buildTypes/StotybookApp.kt b/.teamcity/OpenSourceProjects_Storybook/buildTypes/StotybookApp.kt index e30bd54b3bc3..0c43b087072c 100644 --- a/.teamcity/OpenSourceProjects_Storybook/buildTypes/StotybookApp.kt +++ b/.teamcity/OpenSourceProjects_Storybook/buildTypes/StotybookApp.kt @@ -9,6 +9,7 @@ import jetbrains.buildServer.configs.kotlin.v2017_2.failureConditions.failOnMetr enum class StorybookApp(val appName: String, val exampleDir: String, val merged: Boolean = true) { CRA("CRA", "cra-kitchen-sink"), VUE("Vue", "vue-kitchen-sink"), + SVELTE("Svelte", "svelte-kitchen-sink"), ANGULAR("Angular", "angular-cli"), POLYMER("Polymer", "polymer-cli"), MITHRIL("Mithril", "mithril-kitchen-sink"), diff --git a/examples/official-storybook/stories/__snapshots__/app-acceptance.stories.storyshot b/examples/official-storybook/stories/__snapshots__/app-acceptance.stories.storyshot index b21bba9770d8..26dab3d069e1 100644 --- a/examples/official-storybook/stories/__snapshots__/app-acceptance.stories.storyshot +++ b/examples/official-storybook/stories/__snapshots__/app-acceptance.stories.storyshot @@ -47,3 +47,11 @@ exports[`Storyshots App|acceptance vue-kitchen-sink 1`] = ` title="vue-kitchen-sink" /> `; + +exports[`Storyshots App|acceptance svelte-kitchen-sink 1`] = ` +