From 108bad5d74ff1eb7825b28acf016de14a19735c4 Mon Sep 17 00:00:00 2001 From: Yann Braga Date: Fri, 16 Dec 2022 12:37:07 +0100 Subject: [PATCH 1/2] improve manager-entries failure message --- code/lib/builder-manager/src/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/code/lib/builder-manager/src/index.ts b/code/lib/builder-manager/src/index.ts index b60436139ee4..9066208d671f 100644 --- a/code/lib/builder-manager/src/index.ts +++ b/code/lib/builder-manager/src/index.ts @@ -82,7 +82,7 @@ export const getConfig: ManagerBuilder['getConfig'] = async (options) => { js: 'try{', }, footer: { - js: '}catch(e){ console.log("ONE OF YOUR MANAGER-ENTRIES FAILED: " + import.meta.url) }', + js: '}catch(e){ console.error("[Storybook] One of your manager-entries failed: " + import.meta.url); throw e; }', }, define: { From a8c8944c84a6179041d64c263b37f3011bf11cd0 Mon Sep 17 00:00:00 2001 From: Norbert de Langen Date: Fri, 16 Dec 2022 12:46:52 +0000 Subject: [PATCH 2/2] fix, we should not throw here --- code/lib/builder-manager/src/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/code/lib/builder-manager/src/index.ts b/code/lib/builder-manager/src/index.ts index 9066208d671f..008944391ca1 100644 --- a/code/lib/builder-manager/src/index.ts +++ b/code/lib/builder-manager/src/index.ts @@ -82,7 +82,7 @@ export const getConfig: ManagerBuilder['getConfig'] = async (options) => { js: 'try{', }, footer: { - js: '}catch(e){ console.error("[Storybook] One of your manager-entries failed: " + import.meta.url); throw e; }', + js: '}catch(e){ console.error("[Storybook] One of your manager-entries failed: " + import.meta.url, e); }', }, define: {