From 2994f88bad69366392cc18cb37fe0561fda82c2e Mon Sep 17 00:00:00 2001
From: Yadong Zhang <zhyd007@gmail.com>
Date: Sun, 14 Aug 2022 06:02:40 +0000
Subject: [PATCH 1/5] fix: handled external 'add' method.

---
 .../source-loader/src/abstract-syntax-tree/parse-helpers.js   | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/code/lib/source-loader/src/abstract-syntax-tree/parse-helpers.js b/code/lib/source-loader/src/abstract-syntax-tree/parse-helpers.js
index 5b2aa2dc2292..f4f21284b496 100644
--- a/code/lib/source-loader/src/abstract-syntax-tree/parse-helpers.js
+++ b/code/lib/source-loader/src/abstract-syntax-tree/parse-helpers.js
@@ -103,7 +103,7 @@ export function handleExportedName(storyName, originalNode, parent) {
 }
 
 export function handleADD(node, parent, storiesOfIdentifiers) {
-  if (!node.property || !node.property.name || node.property.name !== 'add') {
+  if (!node.property || !node.property.name) {
     return {};
   }
 
@@ -130,7 +130,7 @@ export function handleADD(node, parent, storiesOfIdentifiers) {
     return {};
   }
 
-  if (storyName.value) {
+  if (storyName.value && typeof storyName.value !== 'number') {
     const key = sanitize(storyName.value);
     let idToFramework;
     if (key && framework) {

From 9f022f6f05d31e7be45972d8bcaa54356840e408 Mon Sep 17 00:00:00 2001
From: Yadong Zhang <zhyd007@gmail.com>
Date: Sun, 14 Aug 2022 06:35:02 +0000
Subject: [PATCH 2/5] test: updated snapshot.

---
 ...rator.csf.test.js.injectStoryParameters-posix.snapshot | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/code/lib/source-loader/src/abstract-syntax-tree/__snapshots__/inject-decorator.csf.test.js.injectStoryParameters-posix.snapshot b/code/lib/source-loader/src/abstract-syntax-tree/__snapshots__/inject-decorator.csf.test.js.injectStoryParameters-posix.snapshot
index 5b50732e7967..3594fffcb172 100644
--- a/code/lib/source-loader/src/abstract-syntax-tree/__snapshots__/inject-decorator.csf.test.js.injectStoryParameters-posix.snapshot
+++ b/code/lib/source-loader/src/abstract-syntax-tree/__snapshots__/inject-decorator.csf.test.js.injectStoryParameters-posix.snapshot
@@ -4,11 +4,5 @@ exports[`inject-decorator injectStoryParameters - ts - csf includes storySource
 "
 
 
-Basic.parameters = { storySource: { source: \\"() => (\\\\n  <Button onClick={action(\\\\\\"clicked\\\\\\")}>Hello Button</Button>\\\\n)\\" }, ...Basic.parameters };
-WithParams.parameters = { storySource: { source: \\"() => <Button>WithParams</Button>\\" }, ...WithParams.parameters };
-WithDocsParams.parameters = { storySource: { source: \\"() => <Button>WithDocsParams</Button>\\" }, ...WithDocsParams.parameters };
-WithStorySourceParams.parameters = { storySource: { source: \\"() => <Button>WithStorySourceParams</Button>\\" }, ...WithStorySourceParams.parameters };
-WithTemplate.parameters = { storySource: { source: \\"(args: Args) => <Button {...args} />\\" }, ...WithTemplate.parameters };
-WithEmptyTemplate.parameters = { storySource: { source: \\"(args: Args) => <Button {...args} />\\" }, ...WithEmptyTemplate.parameters };
-WithAddFunctionParameters.parameters = { storySource: { source: \\"() => null\\" }, ...WithAddFunctionParameters.parameters };"
+foo.parameters = { storySource: { source: \\"() => console.log('bar')\\" }, ...foo.parameters };"
 `;

From a06d73c5b592e672ff8d7f4b9581a7ab01c61345 Mon Sep 17 00:00:00 2001
From: Yadong Zhang <zhyd007@gmail.com>
Date: Sun, 14 Aug 2022 08:33:43 +0000
Subject: [PATCH 3/5] chore: verify chromatic.

---
 code/examples/html-kitchen-sink/stories/button.stories.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/code/examples/html-kitchen-sink/stories/button.stories.js b/code/examples/html-kitchen-sink/stories/button.stories.js
index 11aef8777335..1d2de3689f54 100644
--- a/code/examples/html-kitchen-sink/stories/button.stories.js
+++ b/code/examples/html-kitchen-sink/stories/button.stories.js
@@ -15,7 +15,7 @@ export const Headings = () =>
 export const Button = () => {
   const btn = document.createElement('button');
   btn.innerHTML = 'Hello Button';
-  btn.addEventListener('click', action('Click'));
+  // btn.addEventListener('click', action('Click'));
   return btn;
 };
 

From 2fff9b73631bbeff593af95b8a4c7a185e290b97 Mon Sep 17 00:00:00 2001
From: Yadong Zhang <zhyd007@gmail.com>
Date: Sun, 14 Aug 2022 09:06:44 +0000
Subject: [PATCH 4/5] test: fixed chromatic.

---
 code/examples/html-kitchen-sink/stories/button.stories.js | 2 +-
 ...rator.csf.test.js.injectStoryParameters-posix.snapshot | 8 +++++++-
 .../src/abstract-syntax-tree/parse-helpers.js             | 2 +-
 3 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/code/examples/html-kitchen-sink/stories/button.stories.js b/code/examples/html-kitchen-sink/stories/button.stories.js
index 1d2de3689f54..11aef8777335 100644
--- a/code/examples/html-kitchen-sink/stories/button.stories.js
+++ b/code/examples/html-kitchen-sink/stories/button.stories.js
@@ -15,7 +15,7 @@ export const Headings = () =>
 export const Button = () => {
   const btn = document.createElement('button');
   btn.innerHTML = 'Hello Button';
-  // btn.addEventListener('click', action('Click'));
+  btn.addEventListener('click', action('Click'));
   return btn;
 };
 
diff --git a/code/lib/source-loader/src/abstract-syntax-tree/__snapshots__/inject-decorator.csf.test.js.injectStoryParameters-posix.snapshot b/code/lib/source-loader/src/abstract-syntax-tree/__snapshots__/inject-decorator.csf.test.js.injectStoryParameters-posix.snapshot
index 3594fffcb172..5b50732e7967 100644
--- a/code/lib/source-loader/src/abstract-syntax-tree/__snapshots__/inject-decorator.csf.test.js.injectStoryParameters-posix.snapshot
+++ b/code/lib/source-loader/src/abstract-syntax-tree/__snapshots__/inject-decorator.csf.test.js.injectStoryParameters-posix.snapshot
@@ -4,5 +4,11 @@ exports[`inject-decorator injectStoryParameters - ts - csf includes storySource
 "
 
 
-foo.parameters = { storySource: { source: \\"() => console.log('bar')\\" }, ...foo.parameters };"
+Basic.parameters = { storySource: { source: \\"() => (\\\\n  <Button onClick={action(\\\\\\"clicked\\\\\\")}>Hello Button</Button>\\\\n)\\" }, ...Basic.parameters };
+WithParams.parameters = { storySource: { source: \\"() => <Button>WithParams</Button>\\" }, ...WithParams.parameters };
+WithDocsParams.parameters = { storySource: { source: \\"() => <Button>WithDocsParams</Button>\\" }, ...WithDocsParams.parameters };
+WithStorySourceParams.parameters = { storySource: { source: \\"() => <Button>WithStorySourceParams</Button>\\" }, ...WithStorySourceParams.parameters };
+WithTemplate.parameters = { storySource: { source: \\"(args: Args) => <Button {...args} />\\" }, ...WithTemplate.parameters };
+WithEmptyTemplate.parameters = { storySource: { source: \\"(args: Args) => <Button {...args} />\\" }, ...WithEmptyTemplate.parameters };
+WithAddFunctionParameters.parameters = { storySource: { source: \\"() => null\\" }, ...WithAddFunctionParameters.parameters };"
 `;
diff --git a/code/lib/source-loader/src/abstract-syntax-tree/parse-helpers.js b/code/lib/source-loader/src/abstract-syntax-tree/parse-helpers.js
index f4f21284b496..5b2ee1402797 100644
--- a/code/lib/source-loader/src/abstract-syntax-tree/parse-helpers.js
+++ b/code/lib/source-loader/src/abstract-syntax-tree/parse-helpers.js
@@ -103,7 +103,7 @@ export function handleExportedName(storyName, originalNode, parent) {
 }
 
 export function handleADD(node, parent, storiesOfIdentifiers) {
-  if (!node.property || !node.property.name) {
+  if (!node.property || !node.property.name || node.property.name !== 'add') {
     return {};
   }
 

From 24efe76329d086ee33fb10805cc6e6b56a64e3e7 Mon Sep 17 00:00:00 2001
From: Yadong Zhang <zhyd007@gmail.com>
Date: Sun, 14 Aug 2022 09:21:26 +0000
Subject: [PATCH 5/5] refactor: narrowed down the value type (consist with
 sanitize fn signature).

---
 .../lib/source-loader/src/abstract-syntax-tree/parse-helpers.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/code/lib/source-loader/src/abstract-syntax-tree/parse-helpers.js b/code/lib/source-loader/src/abstract-syntax-tree/parse-helpers.js
index 5b2ee1402797..920f4fe12347 100644
--- a/code/lib/source-loader/src/abstract-syntax-tree/parse-helpers.js
+++ b/code/lib/source-loader/src/abstract-syntax-tree/parse-helpers.js
@@ -130,7 +130,7 @@ export function handleADD(node, parent, storiesOfIdentifiers) {
     return {};
   }
 
-  if (storyName.value && typeof storyName.value !== 'number') {
+  if (storyName.value && typeof storyName.value === 'string') {
     const key = sanitize(storyName.value);
     let idToFramework;
     if (key && framework) {