Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] prop-types missing in dependencies #49

Open
onichandame opened this issue Sep 6, 2021 · 0 comments
Open

[Bug] prop-types missing in dependencies #49

onichandame opened this issue Sep 6, 2021 · 0 comments
Labels

Comments

@onichandame
Copy link

Describe the bug

This addon requires prop-types as a direct dependency, but does not declare it in either dependencies or peerDependencies. A quick search in issues does not give me any result.

Steps to reproduce the behavior

  1. create a project using yarn v2 pnp
  2. add storybook and this addon
  3. run storybook to see the error

Expected behavior

no error

Screenshots and/or logs

无标题

Environment

N/A

Additional context

N/A

Workaround

in yarnrc.yml

packageExtensions:
  "@storybook/addon-console@*":
    dependencies:
      prop-types: "*"
@onichandame onichandame added the bug label Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant