-
-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Documentation]: Update RN documentation around AsyncStorage #7
Comments
Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks! |
Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook! |
Hey @jsjoeio . If you can find a place to put this information somewhere in the documentation, the PR is very welcome :) |
Awesome sauce! Thanks for following up on this. I'll find a place an open a PR :) |
@Gongreg after adding asyncStorage I'm not seeing the app return to my last visited story on refresh, is there any other config required for this to work? |
Hey @dannyhw, how did you enable it? What did you pass to asyncStorage? |
However I also tried with |
Did you fully link it? https://github.com/react-native-community/async-storage There is information about linking it. |
😅 I just changed |
glad that it works :) |
I did this but forgot to close the issue: Closing via storybookjs/storybook#9494 |
Is your feature request related to a problem? Please describe.
I'm new user of Storybook. We're using it on a React Native project. I've upgraded to the
@next
version to remove a warning aboutAsyncStorage
per the recommendation here: https://github.com/storybookjs/storybook/issues/6078#issuecomment-549834805Now, I see a new warning, which suggests I follow the
MIGRATION.md
guide, which takes me here: https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#react-native-async-storageI see the solutions (thank you for those!), but now I'm wondering if I'm choosing the right one.
Also wondering, "What are the benefits of using AsyncStorage within Storybook? It doesn't tell me, and I am struggling to find any documentation around this.
The only relevant info I've found is the PR which adds in the new change:
Describe the solution you'd like
I'd love to see some documentation around why, I as a developer, should use AsyncStorage with React Native Storybook.
Describe alternatives you've considered
I could just leave it as is and not say anything, but I figure I'm not the only one who may stumble into this scenario. And I like what Storybook provides for us, so I'd like to give back.
Are you able to assist bring the feature to reality?
Yes, I'd be happy to update the docs or the
MIGRATION.md
.Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: