Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.0] Remove FunctionComponent type #212

Closed
dannyhw opened this issue Jul 12, 2021 · 1 comment · Fixed by #217
Closed

[6.0] Remove FunctionComponent type #212

dannyhw opened this issue Jul 12, 2021 · 1 comment · Fixed by #217
Assignees
@Patil2099
Labels
6.5 good first issue Good for newcomers

Comments

@dannyhw
Copy link
Member

dannyhw commented Jul 12, 2021 •
edited
Loading

As a follow up on #182

Originally posted by @lauriharpf in #182 (comment)

We might want to not use FunctionComponent or FC, as the React core team seems to lean on the side of "don't use it": facebook/create-react-app#8177

We could tackle this by running https://github.com/gndelia/codemod-replace-react-fc-typescript on the codebase.
@dannyhw dannyhw added 6.5 good first issue Good for newcomers labels Jul 12, 2021
@dannyhw dannyhw added this to the v6 alpha 3 milestone Jul 12, 2021
@Patil2099
Copy link
Contributor

I would love to work on this

@Patil2099 Patil2099 mentioned this issue Jul 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Patil2099 Patil2099

Labels
6.5 good first issue Good for newcomers
Projects
React Native Storybook
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[6.0] Removed FunctionComponent type Patil2099/react-native
2 participants
@dannyhw @Patil2099