-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install storybook for ember #33
Comments
Thanks ! Also https://storybook.js.org/docs/guides/guide-ember/ alone doesn't work as mentioned above, in the current situation, you need to do |
Related issue on storybook repo: storybookjs/storybook#10074 |
Sorry for piggyback on this issue, but there's something that might also be in the interest of this. While trying to add the ember cli to a new project that will back the Intro to Storybook tutorial i'm faced with the following error: ember install @storybook/ember-cli-storybook
Installing packages... This might take a couple of minutes.
npm: Installed @storybook/ember-cli-storybook
installing ember-cli-storybook
The `ember generate <entity-name>` command requires an entity name to be specified. For more details, use `ember help`. The output of ember --version
ember-cli: 3.17.0
node: 12.15.0
os: win32 x64 Steps taken: 1- Also based on the documentation, if you change the storybook script to the following: > [email protected] storybook C:\Users\MyUser\MyFolder\storybook-related\learnstorybook_with_ember\taskbox
> npm run start & start-storybook -p 6006 -s dist
> [email protected] start C:\Users\MyUser\MyFolder\storybook-related\learnstorybook_with_ember\taskbox
> ember serve
Generating files needed by Storybook
Parsing C:\Users\MyUSer\AppData\Local\Temp\broccoli-18696VE7FWlrViX4y\out-247-append_ember_auto_import_analyzer\tests\index.html
Generating preview-head.html
Generating files needed by Storybook
Generating .env
Build successful (9219ms) – Serving on http://localhost:4200/
Slowest Nodes (totalTime => 5% ) | Total (avg)
----------------------------------------------+---------------------
Babel: @ember/test-helpers (2) | 2323ms (1161 ms)
Package /assets/vendor.js (1) | 1681ms
BroccoliRollup (6) | 1534ms (255 ms)
ember-auto-import-analyzer (3) | 586ms (195 ms) Me or any other user needs to issue As the package "storybook-dev":"npm-run-all --aggregate-output --continue-on-error --parallel start storybook" And got both working correctly even with the error mentioned above. Feel free to provide feedback |
So, apparently:
should also run:
primarily the generator should do this: This line here is what we currently think is relevant for the failure:
So, let's keep this issue open until fixed. Related to: chromaui/learnstorybook.com#306 |
There was a conversation on ember discord today: https://discordapp.com/channels/480462759797063690/662337973995700224/732916663111909407 (please scroll down). Mainly chris manson was providing a good hint about scoped packages and default blueprint resolution: Want to keep it here, to save the information. |
The error as a result of the default blueprint not running should be fixed in #57. |
After a discussion in discord:
Installing storybook for ember should be straightforward and only minimal effort.
With ember:
With npx (as mentioned on the Quickstart Guide):
(that command should detect ember and then install
ember-cli-storybook
)After installation is run, developers make their changes in
.storybook/
folder.The text was updated successfully, but these errors were encountered: