Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svelte and Vue examples doesnt work #157

Closed
olemarius opened this issue Nov 18, 2021 · 8 comments · Fixed by #160
Closed

Svelte and Vue examples doesnt work #157

olemarius opened this issue Nov 18, 2021 · 8 comments · Fixed by #160

Comments

@olemarius
Copy link

olemarius commented Nov 18, 2021

I cloned storybook-builder-vite (1.8.0) and tried running the example projects. React works, but Vue and Svelte fails.

OS is Windows 11

Update:
Same thing on tag 2.0.0, but 1.3.0 works.

@IanVS
Copy link
Member

IanVS commented Nov 18, 2021

Thanks for the report. Can you please try 0.1.7?

Also, can you share what version of storybook you are using? And are you using features.storyStoreV7?

@olemarius
Copy link
Author

I tested 1.1.7 and 2.0.0, no changes just ran yarn install and run sb. Will investigate more asap.

@IanVS
Copy link
Member

IanVS commented Nov 18, 2021

There's no 2.0.0, the 0.2.0 tag was a mistake. What version of storybook are you using, and are you using storyStoreV7?

@olemarius
Copy link
Author

olemarius commented Nov 19, 2021

I'm testing again now. Apologies for being a bit unclear yesterday, had my hands a bit full.. Made sure to delete node_modules and do a clean yarn install for each tag I tested today:

0.1.3 works
0.1.7 works
0.1.8 does not work. See below screenshots.

Storybook version on 0.1.8 is Storybook 6.4.0-rc.2 for Vue3

Steps to reproduce

  1. clone https://github.com/eirslett/storybook-builder-vite.git
  2. git checkout v0.1.8
  3. yarn install
  4. run storybook script in examples-vue/packages.json

image
image

Haven't looked into storyStoreV7 yet, but if you've enabled it in examples-vue on tag 0.1.8 then yes. I did no changes to the source code when testing.

@IanVS
Copy link
Member

IanVS commented Nov 19, 2021

@joshwooding any ideas what might be going on here?

@olemarius
Copy link
Author

olemarius commented Nov 19, 2021

When I enabled storyStoreV7 in 0.1.7 I got the same error. Is it enabled by default in 0.1.8? It's not added in main.js in vue-example.

image

@joshwooding
Copy link
Member

joshwooding commented Nov 19, 2021

Hmm, I think this is caused by two versions of @storybook/client-api.

Edit: Yep, @storybook/vue3 has it's own node_modules leading to a duplication of @storybook/client-api not sure why yet.

Edit: Just confirmed the same is happening to @storybook/svelte

@joshwooding
Copy link
Member

This is the same issue as #50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants