Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Round 2 design QA #60

Closed
Tracked by #22558
domyen opened this issue Jun 16, 2023 · 0 comments · Fixed by #61
Closed
Tracked by #22558

Round 2 design QA #60

domyen opened this issue Jun 16, 2023 · 0 comments · Fixed by #61

Comments

@domyen
Copy link
Member

domyen commented Jun 16, 2023

Really excited about this work. Below is second pass at design QA.

Dark mode

Overlay mask in dark mode: blue border is tough to see, can we make it more visible?
image

Position of tooltip feels too far away from the overlay mask so I'm having trouble connecting the two things visually. Can we make the distance between the tip and the mask 6px, currently it looks like it's 10 or 12px.
image

When overlay mask is presented atop the canvas, the border radius is still present which leads to a visual artifact in the corner
image

Set line-height to 18px
image

Minor grammar tweak for punchier copy "You've learned" » "You learned"
image

Missing bottom border
image

Tough to see the X, it's darker in the design
image

Remove offset on title
image

  • Set line-height to 18px (right now it uses system default which is 17.5px).
  • Set the margin from between <h3> to <p> to 10px, it also uses the system default.
image

This code should look like the other inline code elements. i.e., monospace font
image
What the standard inline code element looks like in SB
image

  • Align the circle and the text so that the first line of text is vertically centered with
  • Add a period to the end of each step
image

Two paragraphs reads strange. Can we make it 1 paragraph and shorten the copy to:

You just created your first story. Continue setting up your project to write stories for your own components.

image

Light mode

Line spacing looks irregular because of the inline code, can we make it consistent?
image

@shilman shilman transferred this issue from storybookjs/storybook Jun 17, 2023
@cdedreuille cdedreuille mentioned this issue Jun 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants