Skip to content
This repository has been archived by the owner on Nov 10, 2017. It is now read-only.

Show storyshots in UI #60

Closed
SpaceK33z opened this issue Dec 6, 2016 · 0 comments
Closed

Show storyshots in UI #60

SpaceK33z opened this issue Dec 6, 2016 · 0 comments

Comments

@SpaceK33z
Copy link

SpaceK33z commented Dec 6, 2016

It would be great if the storyshot tests were visible in the Storybook UI, like storybook-addon-specifications. At the moment the storyshots are not in the same "development flow", because you have to open your terminal each time to see the storyshots.

A next step would be to have a button you can click to update the storyshot if it failed.

I might be able to work on this during the holidays. Just to start of the discussion, how could I implement this (roughly)?

The current idea I have is to hook into the Storybook server (which should be possible since storybookjs/storybook#435) and install a WebSocket. Storyshots would use this WebSocket to push the failed / successful storyshots. On the client, there is storybook-channel-websocket to listen / push things to the WebSocket.

Or would it be cleaner to make a separate addon for this? I think all storyshots users would want this, so that's why I'm leaning towards adding it in storyshots at the moment.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants