Skip to content
This repository has been archived by the owner on Dec 13, 2017. It is now read-only.

Violation from info add on #11

Closed
robinglen opened this issue Jun 2, 2017 · 5 comments
Closed

Violation from info add on #11

robinglen opened this issue Jun 2, 2017 · 5 comments

Comments

@robinglen
Copy link

robinglen commented Jun 2, 2017

Hello,

Using a11y addon with info addon causes a violation as it tries to validate the color contrast of the show info toggle.

See attached image:

screenshot

Is there a work around for this?

Thanks,
Rob

@ndelangen
Copy link
Collaborator

Hi @thearegee Sorry, this will not happen soon, likely both addons will need refactoring to fix this, possibly with api changes.

@jbovenschen
Copy link
Collaborator

This is most likely an issue with the order of both decorators, if this addon is loaded before the info-addon it will try to validate the components inside that also.

If we want to fix this we should have a way to get a reference to the story, don't know if anything like that is viable inside storybook @ndelangen?

@ndelangen
Copy link
Collaborator

What is planned is to have info render in a panel instead of the preview.

@chrisdhanaraj
Copy link

@thearegee easiest way for now is just override the color to something accessible

#root > div > div > a[role="button"] {
  background-color: #3d70b2 !important;
}

is what we're doing

@ndelangen
Copy link
Collaborator

FYI I have merged this repo into the monorepo!

Please do not open any issues or PR's directly on this repo, but instead open them here:
https://github.com/storybooks/storybook

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

4 participants