Skip to content
This repository has been archived by the owner on Nov 10, 2017. It is now read-only.

Only works when "Remote JS Debug" is on #3

Closed
thani-sh opened this issue Jun 18, 2016 · 4 comments
Closed

Only works when "Remote JS Debug" is on #3

thani-sh opened this issue Jun 18, 2016 · 4 comments
Milestone
Initial Release

Comments

@thani-sh
Copy link
Contributor

The websocket connection only works when the "Remote JS Debug" is on and the debugger tab is also available. Find out why and fix it.
@thani-sh thani-sh mentioned this issue Jun 18, 2016
Closed
@arunoda
Copy link
Contributor

arunoda commented Jun 19, 2016 •
edited
Loading

We don't need websockets. Use socket.io. It'll use XHR if websocket is not available. We should not need to worry on these stuff.

@thani-sh
Copy link
Contributor Author

thani-sh commented Jun 19, 2016 •
edited
Loading

Already using socket.io. It's quite buggy btw, had to use a patched version to get it to work. This issue is not related to that.

@arunoda arunoda added this to the Initial Release milestone Jun 22, 2016
@arunoda
Copy link
Contributor

arunoda commented Jun 22, 2016

@mnmtanish I added this to the initial release.

@thani-sh
Copy link
Contributor Author

Fixed with #17

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Milestone
Initial Release
Development

No branches or pull requests
2 participants
@arunoda @thani-sh