Minor Behavior Changes

[super3]

• Change 'Minimize to Tray' to 'Display in Tray'
• If selected, then always display in tray on all platforms
• If you hit the 'X' close button the app will hide
• Left click bring app into context
• Right click context menu

[littleskunk]

@super3
Tray icon menu on windows has this order:

Restore
Quit
Drives + Submenu

Quit should stay at last position. Better order would be

Restore
Drive + Submenu
Quit

I did not check the menu on osx and linux.

[GalumphingCallooh]

Agreed on the menu re-ordering. FYI: there is no right-click distinction on our Linux targets for system tray icons, so left and right will both bring up the context menu here, but we can add a focus option for left-click on OSX and Win still.

[GalumphingCallooh]

Pull #163

[darkbluelight]

I'm running DriveShare 0.5.0 on Debian 8 testing (aka stretch) with Kernel 4.3.0-1amd64 x86_64 and with MATE desktop 1.10.2.
Right click on the tray symbol shows me the Restore, Quit, Drives. Left-click on the tray symbol does nothing. Clicking on drives and then on Running: ... crashes the DriveShare GUI. The symbol disappears but DriveShare processes remain running in the background.
(btw awesone job you are doing with storj !)

[littleskunk]

I have to write down a litte review checklist. I don't want to miss something. I am using the autobin binaries for the develop branch.

Ubuntu (gnome)
Display in System Tray
No duplicate instance allowed.
New tray menu order.
X hide the gui.
X close the gui if tray icon option not set.
Right click show menu.
Left click not working.

Windows
Display in System Tray
No duplicate instance allowed.
New tray menu order.
X hide the gui.
X close the gui if tray icon option not set.
Left click restore gui.
Right click show menu.

OSX
Display in System Tray
No duplicate instance allowed.
X always hide the gui without tray icon. (expected behavior as far as i know)
Left click restore gui.
Right click show menu with only one default entry "open".

Not working:
Windows tray icon is hidden in a drop down menu. Start the gui a second time is not working. It looks like the gui is broken. I can hit the desktop icon or task bar icon but nothing happens. The gui is still running in the background. Can you bringt it to the front? Same problem on ubuntu and osx but there the tray icon is not hidden in a drop down menu.

ubuntu left click doesn't bring the gui in front. Right-click->restore is not far away and works. Is it the expected behavior for linux?

No tray icon menu for osx. Other programms have menus for there task bar icons. Where is the menu expected for osx?

[GalumphingCallooh]

Yes, the Windows tray icon in the drop-down is simply how Windows handles these icons and can be changed in OS settings, but not by the app. We're purposefully preventing the GUI from displaying in two instances, so this is a feature we want. I'm testing on a Win 7 vm and seeing the system tray icon restore on left-click, open the context menu on right-click, and get focus when a new instance is attempting to open, without starting a new process.

@littleskunk you're testing the code in pull #163?

[littleskunk]

I am using the autobin binaries. https://github.com/Storj/driveshare-gui/releases/tag/untagged-71f6a1d7f06c5a4ae16f
The release is 5 days old but i deleted the binaries yesterday to get new binaries for the current develop branch (including pull #163)

Please take a look on the task bar icon. As long as the gui is only minimized I get this icon.

It has a litte blue line at the bottom. Start a new process will restore the minimized process. Everything works as expected.

I have problems with the gui if i close it with X. I still have the tray icon but the task bar icon looks different because this time the gui is not only minimized.

Starting a new process is not working for that spezial situation.

[GalumphingCallooh]

I understand what you mean now; confusing to cover and speak about all these cases. So, if a user closes the application with the window manager's "X" button, while the system tray icon is enabled, and the system tray icon is the only part of the app showing, opening a new instance of the app will not restore the currently running app (it will not start a new one either), and we want it to restore the current app. This is a simple fix. Committing now.

[GalumphingCallooh]

Pull #166 for dev branch there to open and focus apps that only exist in sys tray if a second app instance is launched. Testing mac context menu again now. Wait to merge.

[GalumphingCallooh]

Tested Mac. The released .dmg contains the issue; if the current dev codebase is built with npm run release, the mac left-right click issues don't exist. I think maybe the mac binaries were generated prior to the final menu changes.

[littleskunk]

autobin is not working on osx and linux at the moment. Working on a fix.

[littleskunk]

Windows is working now. I see no difference on osx and linux. https://github.com/Storj/driveshare-gui/releases/tag/untagged-4f8af1d97152a3202eff

Autobin script is working on your mac mini. It is using your nodejs installation etc. The main difference is the codebase. Autobin deletes the old codebase and clones your github repository. Maybe in your local codebase are some files that are not commited cause of gitignore? That would explain the different binary result.

[super3]

@MrFancyMonocle @littleskunk Is this issue complete?

[littleskunk]

Open questions:
ubuntu left click doesn't bring the gui in front. Right-click->restore is not far away and works. Is it the expected behavior for linux?

No tray icon menu for osx. Other programms have menus for there task bar icons. Where is the menu expected for osx?

[GalumphingCallooh]

This is the expected behavior for Linux; there's a comment above about it. For Mac, a right-click option displays the menu, which would be a ctrl-click on a one-button mouse or a simple right-click on a two-button mouse with that Mac OS setting enabled.

[littleskunk]

I did a new test and this time i did not use the autobin binaries.

git clone https://github.com/Storj/driveshare-gui -b develop
cd driveshare-gui
npm install
npm start

This is the menu on the system tray icon

This is the menu on the task bar icon

This is the menu from windows.

[tacticalchihuahua]

What's the status of this ticket?

[GalumphingCallooh]

I'm not aware of any outstanding issues here; let's close out, and we'll open a new, specific issue if there's something to work on.