feat: aggregator keeping oldest piece ts #1188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
force-pushed
the
feat/aggregator-keeping-oldest-piece-ts
branch
from
a101b3d
to
b71cdba
Compare
1 task
alanshaw
approved these changes
Nov 28, 2023
|
Age would be more a difference from now to a given date, and not the given date itself. But I can rename from |
vasco-santos
added a commit
that referenced
this pull request
Nov 28, 2023
🤖 I have created a release *beep* *boop* --- ## [4.2.0](filecoin-api-v4.1.2...filecoin-api-v4.2.0) (2023-11-28) ### Features * aggregator keeping oldest piece ts ([#1188](#1188)) ([97a7def](97a7def)) ### Fixes * package metadata ([#1161](#1161)) ([b8a1cc2](b8a1cc2)) * storefront events cron with max concurrency ([#1191](#1191)) ([11010c9](11010c9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: Vasco Santos <[email protected]>
gobengo
pushed a commit
that referenced
this pull request
Nov 28, 2023
Conveniently store the timestamp of the oldest piece in table, so that when monitoring aggregates time to deal for alerts, we do not need to read buffer, decode it, and find out it every time a CRON runs.
gobengo
pushed a commit
that referenced
this pull request
Nov 28, 2023
🤖 I have created a release *beep* *boop* --- ## [4.2.0](filecoin-api-v4.1.2...filecoin-api-v4.2.0) (2023-11-28) ### Features * aggregator keeping oldest piece ts ([#1188](#1188)) ([97a7def](97a7def)) ### Fixes * package metadata ([#1161](#1161)) ([b8a1cc2](b8a1cc2)) * storefront events cron with max concurrency ([#1191](#1191)) ([11010c9](11010c9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: Vasco Santos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conveniently store the timestamp of the oldest piece in table, so that when monitoring aggregates time to deal for alerts, we do not need to read buffer, decode it, and find out it every time a CRON runs.