fix: don't error when we can't figure out a name for a space #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@juliangruber reported an issue with our documented space creation flow when the exported space access delegation doesn't specify a name and the client doesn't specify one manually: #1175 I think it's reasonable to require a name for spaces at some level, but I think the access-client API is too low-level for this.
|
if we do want to update the docs rather than patch as I'm proposing here, we'll need to update https://github.com/web3-storage/w3up/blob/main/packages/w3up-client/src/client.js#L227 to accept a name that can be passed down through |
vasco-santos
approved these changes
Nov 22, 2023
|
Yeah this shouldn't be mandatory. |
alanshaw
pushed a commit
that referenced
this pull request
Nov 22, 2023
🤖 I have created a release *beep* *boop* --- ## [18.0.3](access-v18.0.2...access-v18.0.3) (2023-11-22) ### Fixes * don't error when we can't figure out a name for a space ([#1177](#1177)) ([a31f667](a31f667)) * package metadata ([#1161](#1161)) ([b8a1cc2](b8a1cc2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: Alan Shaw <[email protected]>
gobengo
pushed a commit
that referenced
this pull request
Nov 28, 2023
@juliangruber reported an issue with our documented space creation flow when the exported space access delegation doesn't specify a name and the client doesn't specify one manually: #1175 I think it's reasonable to require a name for spaces at some level, but I think the access-client API is too low-level for this.
gobengo
pushed a commit
that referenced
this pull request
Nov 28, 2023
🤖 I have created a release *beep* *boop* --- ## [18.0.3](access-v18.0.2...access-v18.0.3) (2023-11-22) ### Fixes * don't error when we can't figure out a name for a space ([#1177](#1177)) ([a31f667](a31f667)) * package metadata ([#1161](#1161)) ([b8a1cc2](b8a1cc2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: Alan Shaw <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@juliangruber reported an issue with our documented space creation flow when the exported space access delegation doesn't specify a name and the client doesn't specify one manually:
#1175
I think it's reasonable to require a name for spaces at some level, but I think the access-client API is too low-level for this.