feat: optionally require plans for provisioning #1087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need this to ship billing, to stop users without a payment provider plan from provisioning new spaces. I've added a flag to the `ProviderServiceContext` that lets us disable this requirement - this is extremely useful in testing and will be helpful as we roll this feature out - ie, w3infra can disable this requirement until we are ready to launch.
alanshaw
approved these changes
Nov 7, 2023
|
ah I like it - I'd like |
travis
pushed a commit
that referenced
this pull request
Nov 7, 2023
🤖 I have created a release *beep* *boop* --- ## [7.2.0](upload-api-v7.1.2...upload-api-v7.2.0) (2023-11-07) ### Features * add usage/report capability ([#1079](#1079)) ([6418b4b](6418b4b)) * optionally require plans for provisioning ([#1087](#1087)) ([b24731b](b24731b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need this to ship billing, to stop users without a payment provider plan from provisioning new spaces.
I've added a flag to the
ProviderServiceContextthat lets us disable this requirement - this is extremely useful in testing and will be helpful as we roll this feature out - ie, w3infra can disable this requirement until we are ready to launch.