From a4c421f585a2bb172b4e4dbfe94f7f9cad895905 Mon Sep 17 00:00:00 2001
From: Garrett Brustkern <gbrustkern@gmail.com>
Date: Mon, 7 Feb 2022 00:15:57 -0600
Subject: [PATCH] fix(rulesets): operation-tags should fail on empty array
 (#2050)

Co-authored-by: Garrett Brustkern <gbrustke@cisco.com>
---
 CONTRIBUTING.md                               |  2 +-
 .../src/oas/__tests__/operation-tags.test.ts  | 22 +++++++++++++++++++
 packages/rulesets/src/oas/index.ts            |  9 +++++++-
 3 files changed, 31 insertions(+), 2 deletions(-)

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 7bd1f6b53..d47bc5d88 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -170,7 +170,7 @@ yarn test.harness
 3. In your terminal, navigate to the directory you cloned Spectral into.
 4. Install the dependencies: `yarn`
 5. Build Spectral: `yarn build`
-6. Run Spectral from your local installation: `./packages/cli/dist/index.js lint [openapi_spec_file]`
+6. Run Spectral from your local installation: `node ./packages/cli/dist/index.js lint [openapi_spec_file] --ruleset /path/to/ruleset.yaml`
 7. Create a new branch for your work: `git checkout -b [name_of_your_new_branch]`
 8. Make changes, add tests, and then run the tests: `yarn test` and `yarn workspace @stoplight/spectral-cli build.binary && yarn test.harness`
 9. Update the documentation if appropriate. For example, if you added a new rule to an OpenAPI ruleset,
diff --git a/packages/rulesets/src/oas/__tests__/operation-tags.test.ts b/packages/rulesets/src/oas/__tests__/operation-tags.test.ts
index 2f51e6eb4..8a990ee0b 100644
--- a/packages/rulesets/src/oas/__tests__/operation-tags.test.ts
+++ b/packages/rulesets/src/oas/__tests__/operation-tags.test.ts
@@ -37,4 +37,26 @@ testRule('operation-tags', [
       },
     ],
   },
+
+  {
+    name: 'tags is empty',
+    document: {
+      swagger: '2.0',
+      paths: {
+        '/todos': {
+          get: {
+            tags: [],
+          },
+        },
+      },
+    },
+    errors: [
+      {
+        code: 'operation-tags',
+        message: 'Operation must have non-empty "tags" array.',
+        path: ['paths', '/todos', 'get', 'tags'],
+        severity: DiagnosticSeverity.Warning,
+      },
+    ],
+  },
 ]);
diff --git a/packages/rulesets/src/oas/index.ts b/packages/rulesets/src/oas/index.ts
index da0a61c10..66c8ea65f 100644
--- a/packages/rulesets/src/oas/index.ts
+++ b/packages/rulesets/src/oas/index.ts
@@ -290,7 +290,14 @@ const ruleset = {
       given: '#OperationObject',
       then: {
         field: 'tags',
-        function: truthy,
+        function: schema,
+        functionOptions: {
+          dialect: 'draft7',
+          schema: {
+            type: 'array',
+            minItems: 1,
+          },
+        },
       },
     },
     'path-declarations-must-exist': {