Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ionic Linting Issues? #5

Closed
lathonez opened this issue Jul 13, 2017 · 4 comments
Closed

Ionic Linting Issues? #5

lathonez opened this issue Jul 13, 2017 · 4 comments

Comments

@lathonez
Copy link

lathonez commented Jul 13, 2017

Hey,

When I run this with Clicker, I get a ton of linting errors from:

ionic-app-scripts lint

Have you applied some config to your ionic projects to get around this?

I'm unsure why it's throwing linting errors from ionic-mocks and nothing else. Seems similar enough to this: https://stackoverflow.com/questions/42483922/exclude-node-modules-from-tslint-in-ionic-2-app

What do you think?

@lathonez
Copy link
Author

FYI I've stopped Ionic from linting and am now running my own linting command instead. You may find this is an issue for others using this module with vanilla Ionic though!

Cheers

@stonelasley
Copy link
Owner

@lathonez sorry about that, I didn't notice any linting errors as I was adding it to clicker (I think). I'll look into this ASAP though in the context of clicker. https://github.com/UintaGroup/axpense is also using ionic-mocks and I linted that whole project last week and am pretty sure I'd have run into it. Either way, I probably should add some linting rules to this project and clean it up a bit more.

@stonelasley
Copy link
Owner

I'm able to reproduce this. I should have an update out this weekend.

@stonelasley
Copy link
Owner

should be good now, linted against tslint-ionic-rules.
b638634

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants