From 75e4a4de03d5b3536433bf9f126654a8719a56f6 Mon Sep 17 00:00:00 2001 From: Moad Zardab Date: Wed, 7 Aug 2024 17:58:12 +0400 Subject: [PATCH] Fixing ACM-12888 by supplying a UID for fixed URL ref in the URL. Grafana should accept this, provided there is no clash, and the linkref will now reference a fixed dashboard URL instead of a grafana generated UID which changes per-installation. Also fixed the query param templating for the severity and health impact. The value of `${severity:queryparam}` already includes the query param tag in it, so the previous template would substitute the tag with `var-health_impact=$var-health_impact=All` instead of `var-health_impact=All`. Signed-off-by: Moad Zardab --- .../grafana/dash-acm-openshift-virtualization-overview.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/operators/multiclusterobservability/manifests/base/grafana/dash-acm-openshift-virtualization-overview.yaml b/operators/multiclusterobservability/manifests/base/grafana/dash-acm-openshift-virtualization-overview.yaml index 66ac37a77..68c9691de 100644 --- a/operators/multiclusterobservability/manifests/base/grafana/dash-acm-openshift-virtualization-overview.yaml +++ b/operators/multiclusterobservability/manifests/base/grafana/dash-acm-openshift-virtualization-overview.yaml @@ -26,6 +26,7 @@ data: "gnetId": null, "graphTooltip": 0, "id": 29, + "uid": "OmpD1ZoSk", "iteration": 1709210609633, "links": [], "panels": [ @@ -357,7 +358,7 @@ data: "value": [ { "title": "", - "url": "d/OmpD1ZoSk/openshift-virtualization-overview?${__url_time_range}&orgId=1&var-alert=All&var-severity=$${severity:queryparam}&refresh=5m&var-health_impact=$${health_impact:queryparam}&var-cluster=${__data.fields.Cluster}" + "url": "d/OmpD1ZoSk/openshift-virtualization-overview?${__url_time_range}&orgId=1&var-alert=All&${severity:queryparam}&refresh=5m&${health_impact:queryparam}&var-cluster=${__data.fields.Cluster}" } ] }