From 8fb0ee305c764329655b0c15ba31682785f6ddff Mon Sep 17 00:00:00 2001 From: Alex Misstear Date: Tue, 23 Apr 2024 14:58:16 -0400 Subject: [PATCH] Remove finalizer from ApplicationSetTemplate ArgoCD automatically sets the `resources-finalizer.argocd.argoproj.io` finalizer on the generated Application so this was redundant. Removing it grants ClusterTemplate admins control over the finalizers on their ApplicationSets should they wish to customize them. Signed-off-by: Alex Misstear --- api/v1alpha1/clustertemplateinstance_utils.go | 3 --- 1 file changed, 3 deletions(-) diff --git a/api/v1alpha1/clustertemplateinstance_utils.go b/api/v1alpha1/clustertemplateinstance_utils.go index 31a01bc..771b6b6 100644 --- a/api/v1alpha1/clustertemplateinstance_utils.go +++ b/api/v1alpha1/clustertemplateinstance_utils.go @@ -183,9 +183,6 @@ func (i *ClusterTemplateInstance) UpdateApplicationSet( Template: argo.ApplicationSetTemplate{ ApplicationSetTemplateMeta: argo.ApplicationSetTemplateMeta{ Name: name, - Finalizers: []string{ - argo.ResourcesFinalizerName, - }, Labels: map[string]string{ CTINameLabel: i.Name, CTINamespaceLabel: i.Namespace,