Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDG videos circumvent Left Mouse Isolation #379

Closed
crssi opened this issue Feb 25, 2020 · 7 comments
Closed

DDG videos circumvent Left Mouse Isolation #379

crssi opened this issue Feb 25, 2020 · 7 comments

Comments

@crssi
Copy link

crssi commented Feb 25, 2020

FF 73.0.1, Windows 10
TC 1.8

Additional to default settings:
General -> Automatic Mode: Check
Isolation -> Global -> Mouse Click -> Left Mouse: Choose anything except Never

Open duckduckgo.com.
Search for whatever video.
Click on any video in the video section.

Expected behavior: link opens only in a new tab/container
Actual behavior: link opens in the same tab/container and in a new tab/container

Cheers

@stoically
Copy link
Owner

Can reproduce. Debug log would be helpful for this one.

@stoically stoically added the bug label Feb 25, 2020
@stoically stoically changed the title Strange behaviour Left Mouse Isolation not working for DDG videos Feb 25, 2020
@crssi
Copy link
Author

crssi commented Feb 25, 2020

I am not sure I understood.
You can reproduce or you can't reproduce?
If you can reproduce, do you need my debug logs?

@stoically
Copy link
Owner

I can, but don't have the time to look into it currently, so when I get the time, already having a debug log would help :)

@crssi
Copy link
Author

crssi commented Feb 25, 2020

I see. Sure, will try to provide one today.

Cheers and thank you

@crssi
Copy link
Author

crssi commented Feb 25, 2020

379.log

@stoically
Copy link
Owner

While looking into this I found that DDG sends the request to the video again after the first request was correctly canceled by TC. I'm not sure how this could be sanely handled by TC, since it's probably some weird JavaScript magic doing this. Best solution probably would be if TC allowed to define a rule like "if originating from DDG always isolate" - which is something that would be possible with #397.

@stoically stoically removed the bug label Jun 10, 2020
@stoically stoically changed the title Left Mouse Isolation not working for DDG videos DDG videos circumvent Left Mouse Isolation Jun 10, 2020
@stoically
Copy link
Owner

Closing since the issue itself can't be solved by TC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants