Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Reopen in container" opens a temporary container anyway #269

Closed
coaxial opened this issue Jun 11, 2019 · 11 comments
Closed

"Reopen in container" opens a temporary container anyway #269

coaxial opened this issue Jun 11, 2019 · 11 comments

Comments

@coaxial
Copy link

coaxial commented Jun 11, 2019

I am probably missing something, but can't figure out what: when navigating to a website with automatic mode enabled, it will load in a temporary container. That's fine. But then I want to reload that tab in a particular container rather than a temporary one, so I right click on the tab and select Reopen in container > My container. This however triggers yet another reload and the tab is eventually open in a new temporary container, rather than My container. Because of this, I can't manually assign a website to always open in its own permanent container so I don't lose login state.

Why is this happening? What am I doing wrong?

@crssi
Copy link

crssi commented Jun 11, 2019

If you want to "fix" some domains to specific container, you can try Containerise. It works very good together with TC.

If you want "migrate" a tab from one container to another, you can peek into Switch Container Plus or Context Plus.

In case you are interested into my TC approach, you can take a look mine configuration.
Left mouse click doesn't leave container, so cross domains logins does not break and your friend is middle mouse click, which always open into a new container, when domain or subdomain is different. Maybe in the future I will switch left and middle mouse click actions.

Cheers

@stoically
Copy link
Owner

Why is this happening? What am I doing wrong?

You probably have Navigation Isolation active, which results in the described behavior. There's unfortunately no way to detect the "Reopen" action and respect it in TC in this case.

You could either switch to a relaxed configuration as described by @crssi or use the TC popup (you can activate it in the advanced preferences at the top), click the menu icon top left, go to actions, and choose "convert to permanent container".

@stoically
Copy link
Owner

stoically commented Jun 28, 2019

@coaxial Just realized that I was wrong - if you have just Global or Per Domain Isolation enabled, reopening in permanent containers should work just fine. Do you by chance also have Multi-Account Containers Isolation enabled? If that's the case, you might want to check out #170 (comment).

@stoically
Copy link
Owner

If you don't have MAC Isolation enabled, that would be a bug. Let me know and I'll reopen the issue and a debug log would also very helpful in that case.

@dvandersluis
Copy link

I am running into this as well, I do not have Multi-Account Containers Isolation enabled, but "Reopen in Container" is opening a new tab and leaving the old one.

temporarycontainer.log

@stoically
Copy link
Owner

stoically commented Jul 3, 2019

@dvandersluis That's expected Firefox behavior, Reopen actually opens a new tab instead of replacing the current one - that's probably because the original tab would lose its history. The issue described here is about reopening in permanent container not working, but getting intercepted by TC isolation.

@stoically
Copy link
Owner

Though, if you're looking for replacing when reopening, then you might want to check out my Switch Container Plus.

@dvandersluis
Copy link

Maybe I misunderstood, but before installing TC, the Reopen context menu item would close the old tab, and now it doesn't anymore. My apologies if this is unrelated. (For what it's worth, I was already using Switch Container, but I tried your Switch Container Plus instead and the behaviour is the same).

@stoically
Copy link
Owner

Yeah, seems unrelated, not sure why that behavior changed for you - and the log shows also no unusual activity from TC.

@stoically
Copy link
Owner

stoically commented Jul 3, 2019

FWIW, the reopen context menu is Firefox native and there are no Add-on APIs to change its behavior in any way.

@dvandersluis
Copy link

Thanks @stoically, I'm not sure what's going on then. Sorry again for the noise in this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants