Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitelist accounts.firefox.com #132

Closed
maxnordlund opened this issue Apr 16, 2018 · 4 comments
Closed

Whitelist accounts.firefox.com #132

maxnordlund opened this issue Apr 16, 2018 · 4 comments

Comments

@maxnordlund
Copy link

maxnordlund commented Apr 16, 2018

Notes

Like https://accounts.firefox.com/settings I think https://accounts.firefox.com/ should be whitelisted to always open in the default container. Doesn't make much sense it open it in another one IMO.

See mozilla/multi-account-containers#1194, which also includes about:addon output.

@stoically
Copy link
Owner

Is there a reason to not just assign accounts.firefox.com to a Permanent Container using MAC and use that Permanent Container for it instead of the Default Container? Since logging into and using Firefox Accounts also works with Temporary Containers I personally don't see the need to add that specific Domain to the "Exclude from Automatic Mode / Isolation"-List. Or do I miss something here and something does indeed not work?

I might consider to make the Exclude-List also available in the preferences while implementing #104 so one could configure custom Domains (alongside with AMO and getpocket).

@maxnordlund
Copy link
Author

It's about logging in to addons.mozilla.org which when I turned off temporary containers worked seamlessly. But I couldn't decontain using https://gitlab.com/mjanetmars/switch-container, it just switched to a new temporary container. I get why that happens, and I don't really consider it a bug as it comes from the interaction between this and MarsCats extension.

It also comes from the Firefox sync feature. It works for me, but I enabled it before automatic mode. Go to about:preferences?entrypoint=menupanel#sync and click the "Manage account" link, it goes to accounts.firefox.com.

If it would be possible to edit in the future that's really awesome, but I do think it should be on the whitelist shipped with temporary containers.

@listalltabs
Copy link

Just for information, accounts.firefox.com is amongst a list of firefox/mozilla domains attached to the new v60 pref extensions.webextensions.restrictedDomains. This appears to stop the listed domains from being isolated from or assigned to a container. (Actually, you can assign them to a container, via MAC, but the assignment isn't honoured).

@stoically
Copy link
Owner

@listalltabs Interesting, just tested and it seems that all domains in extensions.webextensions.restrictedDomains are not able to be seen or canceled by webrequest.onBeforeRequest - and with that can't get reopened into a container; though they still can get loaded in a container if the container is opened first. But with that upcoming change from Firefox, I guess we can close this Issue since it will automatically behave like OP requested with Firefox v60+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants