From 060da14eee143a93fbfbeebe05e9debc5c236fce Mon Sep 17 00:00:00 2001
From: stoically <stoically@protonmail.com>
Date: Tue, 6 Mar 2018 09:26:17 +0100
Subject: [PATCH] Lets not isolate blank tabs

Part of #56
---
 src/background/request.js | 5 +++++
 src/ui/options.html       | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/background/request.js b/src/background/request.js
index 7ab207c2..3521796c 100644
--- a/src/background/request.js
+++ b/src/background/request.js
@@ -382,6 +382,11 @@ class Request {
       return true;
     }
 
+    if (tab.url === 'about:blank') {
+      debug('[shouldIsolate] not isolating because the tab url is blank');
+      return false;
+    }
+
     if (tab.url === 'about:blank' && this.requestsSeen[request.requestId]) {
       debug('[shouldIsolate] not isolating because the tab url is blank and we seen this request before, probably redirect');
       return false;
diff --git a/src/ui/options.html b/src/ui/options.html
index b4556b39..6a53df0c 100644
--- a/src/ui/options.html
+++ b/src/ui/options.html
@@ -144,7 +144,7 @@ <h4 data-tooltip="Website Rules overwrite Global Preferences">
             <div class="field">
               <select id="isolationDomainAction" class="ui fluid dropdown">
                 <option value="always">Always</option>
-                <option value="notsamedomainexact">Only if the navigation target doesn't exactly match the Tabs Website Domain</option>
+                <option value="notsamedomainexact" selected="selected">Only if the navigation target doesn't exactly match the Tabs Website Domain</option>
                 <option value="notsamedomain">Only if the navigation target doesn't match the Tabs Website Domain (includes Subdomains)</option>
                 <option value="never">Never</option>
               </select>