Wrapped drawer in div to prevent scroll and click underneath it. #51
Conversation
|
HI, thanks for your contribution! I will get the chance to review the PR this weekend. |
| if (open) { | ||
| document.body.style.overflowY = 'hidden'; | ||
| } else { | ||
| document.body.style.overflowY = 'auto'; |
There was a problem hiding this comment.
Not a fan of modifying the overflow styles of body. This is a very invasive way to go about this. Can you think of any alternatives to this? I'll try and do some testing this week to this regard as well...
| @@ -64,6 +65,7 @@ | |||
| "1-liners": "^0.4.0", | |||
| "prop-types": "^15.5.10", | |||
| "react-hammerjs": "^1.0.1", | |||
| "react-motion": "^0.5.2" | |||
| "react-motion": "^0.5.2", | |||
| "release-it": "^7.4.7" | |||
There was a problem hiding this comment.
This should be in dev dependencies.
| @@ -12,6 +12,7 @@ | |||
| "patch-release": "npm version patch && npm publish && git push --follow-tags", | |||
| "minor-release": "npm version minor && npm publish && git push --follow-tags", | |||
| "major-release": "npm version major && npm publish && git push --follow-tags", | |||
| "release": "release-it", | |||
There was a problem hiding this comment.
Cool tool! Didn't know this existed. If you could, please rewrite the other -release scripts to use release-it with its various options. Otherwise just remove release-it and I'll implement on my own.
|
Hey @pc9, do you mind reverting those version changes? I'd like to get this merged but the versions might cause issues. |
|
Seems like you have pushed it to your own npm fork, so I'll close this PR. Please open a new one without any of the version or package json changes if you want to have them merged back in. |
Fixes #24