Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discovering module for tests is broken #12

Closed
stoeffel opened this issue Jun 6, 2018 · 4 comments · Fixed by #13
Closed

discovering module for tests is broken #12

stoeffel opened this issue Jun 6, 2018 · 4 comments · Fixed by #13
Labels
bug Something isn't working

Comments

@stoeffel
Copy link
Owner

stoeffel commented Jun 6, 2018

rtfeldman/node-test-runner#258

I think this is because we don't find a module in any of the source directories. We need to check tests (not defined in source-modules) as well.

@stoeffel stoeffel added the bug Something isn't working label Jun 6, 2018
@avh4
Copy link
Collaborator

avh4 commented Jun 6, 2018

The problem in rtfeldman/node-test-runner#258 is that there is an elmi file for an elm source file that no longer exists (the user deleted it). I know there used to be code somewhere that would check that the elm file exists, and if it doesn't, ignore the elmi file. I don't remember if that code was in elmi-to-json, or in node-test-runner? But maybe something's wrong there? I'm pretty sure it is correctly finding the elm file when the elm file does exist. (the tests folder is in the source-directories of the elm.json in elm-stuff/generated/elm-explorations/test, which is where elmi-to-json is not run from).

@stoeffel
Copy link
Owner Author

stoeffel commented Jun 6, 2018

oh got it. I don't remember that there was code for that in elmi-to-json before.

@stoeffel stoeffel closed this as completed Jun 6, 2018
@avh4
Copy link
Collaborator

avh4 commented Jun 6, 2018

I guess I was thinking of this code, which does that check, but throws an error if the source files doesn't exist. https://github.com/stoeffel/elmi-to-json/blob/master/src/Elmi.hs#L29-L33

Could we make it so that elmi-to-json with no arguments will ignore those extra elmi files?

@stoeffel
Copy link
Owner Author

stoeffel commented Jun 6, 2018

Yes that sounds good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants